[GitHub] mrutkows commented on issue #810: wskdeploy assumed "guest" namespace if one is not set

[GitBox <gi...@apache.org>]

mrutkows commented on issue #810: wskdeploy assumed "guest" namespace if one is not set
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/810#issuecomment-374322281
 
 
   @rabbah yes, it is in Go client, we make not assumptions in wskdeploy; however, at one point we copied the code from Go client (no longer) and still have a legacy comment that we default to guest (perhaps the "we" is collectively including the known behavior from Go client):
   
   grep -rn "guest" . 
   ```
   ./wski18n/resources/en_US.all.json:236:    "translation": "\nPlease provide a namespace [default value is guest]: "
   ./deployers/whiskclient_test.go:46:	WSKPROPS_NAMESPACE = "guest"
   ./parsers/manifest_parser.go:248:	//The namespace for this package is absent, so we use default guest here.
   ./parsers/manifest_parser.go:968: *			"namespace":"guest",
   ```
   
   @pritidesai  We do need to remove the translated string that indicates we default to guest as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services