You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2022/12/05 13:37:51 UTC
[GitHub] [brooklyn-ui] jathanasiou opened a new pull request, #363: Fix/catalog saver defaults
jathanasiou opened a new pull request, #363:
URL: https://github.com/apache/brooklyn-ui/pull/363
Adjustments and some refactoring to allow CatalogSaver to better handle default and initial values for the modal dialog fields.
This ensures the defaults adapt properly to user-defined names given in the Editor, who is the parent of the modal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #363: Fix/catalog saver defaults
Posted by GitBox <gi...@apache.org>.
ahgittin commented on PR #363:
URL: https://github.com/apache/brooklyn-ui/pull/363#issuecomment-1339034669
Fix looks good. Can you squash the commits and force push? In this case that part of history is unhelpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #363: Fix/catalog saver defaults
Posted by GitBox <gi...@apache.org>.
ahgittin commented on PR #363:
URL: https://github.com/apache/brooklyn-ui/pull/363#issuecomment-1339034865
(I will merge as soon as that is done.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] asfgit merged pull request #363: Fix/catalog saver defaults
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #363:
URL: https://github.com/apache/brooklyn-ui/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org