[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5363: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

["slfan1989 (via GitHub)" <gi...@apache.org>]

slfan1989 commented on code in PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#discussion_r1136397973


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -4306,18 +4306,18 @@ public static boolean isAclEnabled(Configuration conf) {
       ROUTER_PREFIX + "interceptor.allow-partial-result.enable";
   public static final boolean DEFAULT_ROUTER_INTERCEPTOR_ALLOW_PARTIAL_RESULT_ENABLED = false;
 
+  /** Subcluster timeout allowed by Router.  **/

Review Comment:
   Thank you very much for your help to review the code, I will modify the code.



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRouterCLI.java:
##########
@@ -49,6 +73,33 @@ protected ResourceManagerAdministrationProtocol createAdminProtocol() {
     };
   }
 
+  private DeregisterSubClusterResponse generateSubClusterDataBySCId(String subClusterId) {
+    // Step2. generate return data.
+    String lastHeartBeatTime = new Date().toString();
+    DeregisterSubClusters deregisterSubClusters =
+        DeregisterSubClusters.newInstance(subClusterId, "SUCCESS", lastHeartBeatTime,
+        "Heartbeat Time > 30 minutes", "SC_LOST");
+    List<DeregisterSubClusters> deregisterSubClusterList = new ArrayList<>();
+    deregisterSubClusterList.add(deregisterSubClusters);
+
+    // Step3. return data.
+    return DeregisterSubClusterResponse.newInstance(deregisterSubClusterList);
+  }
+
+  private DeregisterSubClusterResponse generateAllSubClusterData() {
+    List<DeregisterSubClusters> deregisterSubClusterList = new ArrayList<>();
+    for (int i = 1; i <= 4; i++) {

Review Comment:
   I will modify the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org