You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/16 17:43:24 UTC
[GitHub] [flink] godfreyhe opened a new pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
godfreyhe opened a new pull request #12688:
URL: https://github.com/apache/flink/pull/12688
## What is the purpose of the change
*TableEnvironment.executeSql() method for INSERT statement returns TableResult once the job is submitted. Users must use tableResult.getJobClient.get().getJobExecutionResult(Thread.currentThread().getContextClassLoader).get() to wait the job finish. This API looks very ugly. This pr aims to introduce TableResult#await method to make the api fluent*
## Brief change log
- *Introduce await in TableResult*
- *remove TableEnvUtil and update the related tests*
- *remove the usage of tableResult.getJobClient.get().getJobExecutionResult().get() in planner tests*
## Verifying this change
This change is already covered by existing tests*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a66d075fe969ae716d3700ad4661482b6c79dc05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651)
* 51d8c4c4c144431d425dace01ee07e5fb49d83cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
}, {
"hash" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747",
"triggerID" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"triggerType" : "PUSH"
}, {
"hash" : "9fc17e0aa967718f9092013449fbe3d5f6439671",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6143",
"triggerID" : "9fc17e0aa967718f9092013449fbe3d5f6439671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9fc17e0aa967718f9092013449fbe3d5f6439671 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6143)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5faf25907847b21760e55c5f72c53ae424e38724 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672)
* 1055cf86422cc0447c2acfde4f59899ed5ff7eea UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5faf25907847b21760e55c5f72c53ae424e38724 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
}, {
"hash" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747",
"triggerID" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"triggerType" : "PUSH"
}, {
"hash" : "9fc17e0aa967718f9092013449fbe3d5f6439671",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6143",
"triggerID" : "9fc17e0aa967718f9092013449fbe3d5f6439671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80045af402b30c622b2ed67e3f2b3109e4a65c07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747)
* 9fc17e0aa967718f9092013449fbe3d5f6439671 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6143)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
}, {
"hash" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5faf25907847b21760e55c5f72c53ae424e38724 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672)
* 1055cf86422cc0447c2acfde4f59899ed5ff7eea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708)
* 80045af402b30c622b2ed67e3f2b3109e4a65c07 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #12688:
URL: https://github.com/apache/flink/pull/12688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51d8c4c4c144431d425dace01ee07e5fb49d83cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665)
* 5faf25907847b21760e55c5f72c53ae424e38724 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5faf25907847b21760e55c5f72c53ae424e38724 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672)
* 1055cf86422cc0447c2acfde4f59899ed5ff7eea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51d8c4c4c144431d425dace01ee07e5fb49d83cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a66d075fe969ae716d3700ad4661482b6c79dc05 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a66d075fe969ae716d3700ad4661482b6c79dc05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651)
* 51d8c4c4c144431d425dace01ee07e5fb49d83cc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-686333942
@twalthr I have updated the pr based on latest comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
}, {
"hash" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747",
"triggerID" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"triggerType" : "PUSH"
}, {
"hash" : "9fc17e0aa967718f9092013449fbe3d5f6439671",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9fc17e0aa967718f9092013449fbe3d5f6439671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80045af402b30c622b2ed67e3f2b3109e4a65c07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747)
* 9fc17e0aa967718f9092013449fbe3d5f6439671 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
}, {
"hash" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747",
"triggerID" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5faf25907847b21760e55c5f72c53ae424e38724 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672)
* 1055cf86422cc0447c2acfde4f59899ed5ff7eea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708)
* 80045af402b30c622b2ed67e3f2b3109e4a65c07 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
}, {
"hash" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747",
"triggerID" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80045af402b30c622b2ed67e3f2b3109e4a65c07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a66d075fe969ae716d3700ad4661482b6c79dc05 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a66d075fe969ae716d3700ad4661482b6c79dc05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51d8c4c4c144431d425dace01ee07e5fb49d83cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665)
* 5faf25907847b21760e55c5f72c53ae424e38724 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-645789012
@twalthr Thanks for the suggestion, I have updated the pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12688:
URL: https://github.com/apache/flink/pull/12688#discussion_r441930424
##########
File path: flink-python/pyflink/table/table_result.py
##########
@@ -48,6 +51,22 @@ def get_job_client(self):
else:
return None
+ def wait(self, timeout_ms=None):
Review comment:
`await` is a keyword in python.
just like `as` method in `Table`, python `Table` uses `alias`.
now flink-python does not defined Exceptions, java exception will be thrown directly. example: python `Catalog` class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12688:
URL: https://github.com/apache/flink/pull/12688#discussion_r441930424
##########
File path: flink-python/pyflink/table/table_result.py
##########
@@ -48,6 +51,22 @@ def get_job_client(self):
else:
return None
+ def wait(self, timeout_ms=None):
Review comment:
`await` is a keyword in python.
just like `as` method in `Table`, python `Table` uses `alias`.
now flink-python does not define Exceptions, java exception will be thrown directly. example: python `Catalog` class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644912723
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a66d075fe969ae716d3700ad4661482b6c79dc05 (Tue Jun 16 17:45:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18337).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #12688:
URL: https://github.com/apache/flink/pull/12688#discussion_r441519689
##########
File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java
##########
@@ -135,7 +126,7 @@ public void testTableSourceFullScan() throws Exception {
" h.family3.col3 " +
"FROM hTable AS h");
Review comment:
For all locations that were updated in the previous commit the declared `throws Exception` is not necessary anymore. My IDE shows a lot of warnings `Exception 'java.lang.Exception' is never thrown in the method ` which we can fix in this PR.
##########
File path: flink-python/pyflink/table/table_result.py
##########
@@ -48,6 +51,22 @@ def get_job_client(self):
else:
return None
+ def wait(self, timeout_ms=None):
Review comment:
call it `await` to be consistent. how are the exceptions handled in Python?
##########
File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java
##########
@@ -135,7 +126,7 @@ public void testTableSourceFullScan() throws Exception {
" h.family3.col3 " +
"FROM hTable AS h");
- List<Row> results = collectBatchResult(table);
+ List<Row> results = Lists.newArrayList(table.execute().collect());
Review comment:
avoid dependencies to other modules for simple util functions. Introduce an overloaded method `org.apache.flink.util.CollectionUtil#iteratorToList` in a hotfix commit
##########
File path: flink-python/pyflink/table/table_result.py
##########
@@ -48,6 +51,22 @@ def get_job_client(self):
else:
return None
+ def wait(self, timeout_ms=None):
+ """
+ Wait if necessary for at most the given time (milliseconds) for the data to be ready.
+
+ For select operation, this method will wait unit the first row can be accessed in local.
Review comment:
For a select operation, this method will wait until the first row can be accessed locally.
For an insert operation, this method will wait for the job to finish, because the result contains only one row.
For other operations, this method will return immediately, because the result is already available locally.
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java
##########
@@ -284,9 +284,13 @@ public void testStreamingAppend() throws Exception {
tEnv.registerCatalog(hiveCatalog.getName(), hiveCatalog);
tEnv.useCatalog(hiveCatalog.getName());
- TableEnvUtil.execInsertSqlAndWaitResult(
- tEnv,
- "insert into db1.sink_table select 6,'a','b','2020-05-03','12'");
+ try {
+ tEnv.executeSql(
+ "insert into db1.sink_table select 6,'a','b','2020-05-03','12'")
+ .await();
+ } catch (Exception e) {
+ throw new TableException("Failed to execute sql", e);
Review comment:
throw `AssertionError` in tests with `Assert.fail()`.
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -1413,4 +1415,46 @@ protected TableImpl createTable(QueryOperation tableOperation) {
operationTreeBuilder,
functionCatalog.asLookup(parser::parseIdentifier));
}
+
+ /**
+ * Iterator for insert operation result.
+ */
+ private static final class InsertResultIterator implements CloseableIterator<Row> {
Review comment:
`TableEnvironmentImpl` is already quite large. Move it to a separate class in default scope.
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableResultImpl.java
##########
@@ -73,6 +82,50 @@ private TableResultImpl(
return Optional.ofNullable(jobClient);
}
+ @Override
+ public void await() throws InterruptedException, ExecutionException {
+ try {
+ awaitInternal(-1, TimeUnit.MILLISECONDS);
+ } catch (TimeoutException e) {
+ // do nothing
+ }
+ }
+
+ @Override
+ public void await(long timeout, TimeUnit unit)
+ throws InterruptedException, ExecutionException, TimeoutException {
+ awaitInternal(timeout, unit);
+ }
+
+ private void awaitInternal(long timeout, TimeUnit unit)
+ throws InterruptedException, ExecutionException, TimeoutException {
+ if (jobClient == null) {
+ return;
+ }
+
+ ExecutorService executor = Executors.newFixedThreadPool(
+ 1, new ThreadFactoryBuilder().setNameFormat("TableResult-await-thread").build());
Review comment:
avoid guava
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableResult.java
##########
@@ -38,6 +41,33 @@
*/
Optional<JobClient> getJobClient();
+ /**
+ * Wait if necessary until the data is ready.
+ *
+ * <p>For select operation, this method will wait unit the first row can be accessed in local.
+ * For insert operation, this method will wait for the job to finish, because the result contains only one row.
+ * For other operations, this method will return immediately, because the result is ready in local.
+ *
+ * @throws ExecutionException if this future completed exceptionally
Review comment:
`if this future completed exceptionally` it is not really a future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-644921647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3651",
"triggerID" : "a66d075fe969ae716d3700ad4661482b6c79dc05",
"triggerType" : "PUSH"
}, {
"hash" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3665",
"triggerID" : "51d8c4c4c144431d425dace01ee07e5fb49d83cc",
"triggerType" : "PUSH"
}, {
"hash" : "5faf25907847b21760e55c5f72c53ae424e38724",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3672",
"triggerID" : "5faf25907847b21760e55c5f72c53ae424e38724",
"triggerType" : "PUSH"
}, {
"hash" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708",
"triggerID" : "1055cf86422cc0447c2acfde4f59899ed5ff7eea",
"triggerType" : "PUSH"
}, {
"hash" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747",
"triggerID" : "80045af402b30c622b2ed67e3f2b3109e4a65c07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1055cf86422cc0447c2acfde4f59899ed5ff7eea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3708)
* 80045af402b30c622b2ed67e3f2b3109e4a65c07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12688:
URL: https://github.com/apache/flink/pull/12688#issuecomment-645329578
cc @twalthr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #12688: [FLINK-18337][table] Introduce TableResult#await method to wait for data ready
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #12688:
URL: https://github.com/apache/flink/pull/12688#discussion_r480100558
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/InsertResultIterator.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+
+import java.util.NoSuchElementException;
+import java.util.Optional;
+
+/**
+ * A CloseableIterator for insert operation result.
+ */
+@Internal
+class InsertResultIterator implements CloseableIterator<Row> {
+ private final JobClient jobClient;
+ private final Row affectedRowCountsRow;
+ private Optional<Boolean> hasNext = Optional.empty();
Review comment:
Optional should not be used in fields: https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/InsertResultIterator.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+
+import java.util.NoSuchElementException;
+import java.util.Optional;
+
+/**
+ * A CloseableIterator for insert operation result.
Review comment:
nit: use `{@link CloseableIterator}` in such cases to make refactorings easier in the future
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -241,7 +239,7 @@ class CatalogTableITCase(isStreamingMode: Boolean) extends AbstractTestBase {
|FROM T1
|GROUP BY TUMBLE(ts, INTERVAL '5' SECOND)
""".stripMargin
- execInsertSqlAndWaitResult(tableEnv, query)
+ tableEnv.executeSql(query).await()
Review comment:
nit: wrong indention
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/InsertResultIterator.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+
+import java.util.NoSuchElementException;
+import java.util.Optional;
+
+/**
+ * A CloseableIterator for insert operation result.
+ */
+@Internal
+class InsertResultIterator implements CloseableIterator<Row> {
+ private final JobClient jobClient;
+ private final Row affectedRowCountsRow;
+ private Optional<Boolean> hasNext = Optional.empty();
+
+ InsertResultIterator(JobClient jobClient, Row affectedRowCountsRow) {
+ this.jobClient = jobClient;
+ this.affectedRowCountsRow = affectedRowCountsRow;
+ }
+
+ @Override
+ public void close() throws Exception {
+ jobClient.cancel();
+ }
+
+ @Override
+ public boolean hasNext() {
+ if (!hasNext.isPresent()) {
+ try {
+ jobClient.getJobExecutionResult(Thread.currentThread().getContextClassLoader()).get();
Review comment:
Make the classloader configurable for this class and pass the context classloader higher in the stack. The TableEnvironment will have it soon (see FLINK-15635).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org