You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 14:51:48 UTC

[PR] fix(acl): stop logging plaintext plain-access keys [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3399:
URL: https://github.com/apache/rocketmq-dashboard/pull/3399

   ## Summary
   
   Removes the plaintext `accessKey` from the `log.info` emitted on every plain-access config upsert. The line now logs only non-secret attributes (`admin` flag and whether a whitelist is configured), consistent with the `@ToString.Exclude` convention applied to the credential-bearing ACL rows/VOs.
   
   ## Why
   
   Access keys authenticate RocketMQ plain-ACL clients; logging them at info level on every create/update puts credentials into application logs (a common exfiltration/forensic path). Nothing downstream depends on the logged value.
   
   ## Testing
   
   `mvn -B test -Dtest=AclServiceTest` — 64/64 pass (compile + full service suite); checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(acl): stop logging plaintext plain-access keys [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3399: fix(acl): stop logging plaintext plain-access keys
URL: https://github.com/apache/rocketmq-dashboard/pull/3399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org