You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/22 02:20:02 UTC

[GitHub] [trafficserver] masaori335 commented on pull request #7605: Disable read from client when HttpTunnelConsumer for client is set up

masaori335 commented on pull request #7605:
URL: https://github.com/apache/trafficserver/pull/7605#issuecomment-803717642


   > Is there a reason we don't handle the EOS appropriately? 
   
   The HttpSM is in the `state_watch_for_client_abort` state and it kills HttpTunnel on EOS if `ua_txn->allow_half_open()` returns `false`. Checking what HttpTunnel is doing might be another approach, but I'm not sure it's better than this.
   https://github.com/apache/trafficserver/blob/42db8bb284d63e3f019e2d9d986e4d34f750f69a/proxy/http/HttpSM.cc#L975-L993
   
   
   > Do we also disable reads from the client in the HTTP/2 case? If so, then how does that work for bidirectional communication with HTTP/2?
   
   With HTTP/2, this change disables the read of Http2Stream (just resets `Http2Stream::read_vio` which is used for receiving a request from the client on the stream). 
   The read op of HTTP/2 *connection* is still available.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org