You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2017/11/14 10:36:21 UTC

[GitHub] brooklyn-server pull request #895: Add missing /v1/catalog/bundles REST endp...

GitHub user tbouron opened a pull request:

    https://github.com/apache/brooklyn-server/pull/895

    Add missing /v1/catalog/bundles REST endpoint for karaf distribution

    Without this change, the `/v1/catalog/bundles` REST endpoint is now available when launching through Karaf

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-server fix/rest-bundles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #895
    
----
commit c772063d596f5aa2d5496ce19614b4d9f5cad64f
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date:   2017-11-14T10:34:59Z

    Add missing /v1/catalog/bundles REST endpoint for karaf distribution

----


---

[GitHub] brooklyn-server pull request #895: Add missing REST endpoints for karaf dist...

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/895#discussion_r150796771
  
    --- Diff: rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml ---
    @@ -75,6 +75,7 @@ limitations under the License.
         <bean id="apidocResourceBean" class="org.apache.brooklyn.rest.resources.ApidocResource"/>
         <bean id="applicationResourceBean" class="org.apache.brooklyn.rest.resources.ApplicationResource"/>
         <bean id="catalogResourceBean" class="org.apache.brooklyn.rest.resources.CatalogResource"/>
    +    <bean id="bundlesResourceBean" class="org.apache.brooklyn.rest.resources.BundleResource"/>
    --- End diff --
    
    Good catch! Endpoint added @aledsage 


---

[GitHub] brooklyn-server pull request #895: Add missing REST endpoints for karaf dist...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/895


---

[GitHub] brooklyn-server pull request #895: Add missing REST endpoints for karaf dist...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/895#discussion_r150796695
  
    --- Diff: rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml ---
    @@ -74,18 +74,20 @@ limitations under the License.
         <bean id="adjunctResourceBean" class="org.apache.brooklyn.rest.resources.AdjunctResource"/>
         <bean id="apidocResourceBean" class="org.apache.brooklyn.rest.resources.ApidocResource"/>
         <bean id="applicationResourceBean" class="org.apache.brooklyn.rest.resources.ApplicationResource"/>
    +    <bean id="bundlesResourceBean" class="org.apache.brooklyn.rest.resources.BundleResource"/>
    --- End diff --
    
    Very minor: I'd go for `bundleResourceBean` to be consistent with all the others. Then good to merge!


---

[GitHub] brooklyn-server pull request #895: Add missing REST endpoints for karaf dist...

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/895#discussion_r150797248
  
    --- Diff: rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml ---
    @@ -74,18 +74,20 @@ limitations under the License.
         <bean id="adjunctResourceBean" class="org.apache.brooklyn.rest.resources.AdjunctResource"/>
         <bean id="apidocResourceBean" class="org.apache.brooklyn.rest.resources.ApidocResource"/>
         <bean id="applicationResourceBean" class="org.apache.brooklyn.rest.resources.ApplicationResource"/>
    +    <bean id="bundlesResourceBean" class="org.apache.brooklyn.rest.resources.BundleResource"/>
    --- End diff --
    
    @aledsage updated


---

[GitHub] brooklyn-server pull request #895: Add missing /v1/catalog/bundles REST endp...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/895#discussion_r150795224
  
    --- Diff: rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml ---
    @@ -75,6 +75,7 @@ limitations under the License.
         <bean id="apidocResourceBean" class="org.apache.brooklyn.rest.resources.ApidocResource"/>
         <bean id="applicationResourceBean" class="org.apache.brooklyn.rest.resources.ApplicationResource"/>
         <bean id="catalogResourceBean" class="org.apache.brooklyn.rest.resources.CatalogResource"/>
    +    <bean id="bundlesResourceBean" class="org.apache.brooklyn.rest.resources.BundleResource"/>
    --- End diff --
    
    also need `typesResourceBean` for `TypeResource`


---