You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "nielsbasjes (via GitHub)" <gi...@apache.org> on 2026/03/19 14:00:34 UTC
[PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
nielsbasjes opened a new pull request, #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240
There are situations where tests in projects need the availability of different JDKs that are then used via maven toolchains.
At this time there is no way to add them in a project.
This change (**CURRENTLY UNTESTED**) proposes using this feature https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#installing-multiple-jdks-with-toolchains to add all LTS JDK versions to be available during every build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240#issuecomment-4091025008
I see several skipped jobs that look strange:
<hr/>
<img width="314" height="285" alt="image" src="https://github.com/user-attachments/assets/a0237c37-032b-4aac-8837-8244a6d21df4" />
<hr/>
<img width="314" height="285" alt="image" src="https://github.com/user-attachments/assets/7a296818-7bb5-4015-bc39-51885efe0e3a" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240#issuecomment-4091187177
> I see several skipped jobs that look strange:
>
We have conditions for skip some of jobs/matrix like
```
if: inputs.ff-run
```
If GH evaluate it to false skip job but print unresolved values in skipped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240#issuecomment-4091750824
@slawekjaranowski I expect that with these changes that in some projects more integration tests will be run because suddenly the toolchains condition in the invoker plugin is met.
It would not surprise me if this will result in some projects showing broken builds.
I leave it with you to determine if this change is what you like to go forward with.
If any additional changes are desired then please just tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240#issuecomment-4090910437
@slawekjaranowski I added statements to show the currently active Java and the contents of the toolchains.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240#issuecomment-4090756282
I see many logs like ` Overwriting existing file /Users/runner/.m2/toolchains.xml`
We can add a `cat` or other test that `toolchains.xml` is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Install and make available all LTS JDK versions via Toolchains. [maven-gh-actions-shared]
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #240:
URL: https://github.com/apache/maven-gh-actions-shared/pull/240#issuecomment-4090659648
My argument to (by default) simply install all LTS always for use by toolchains is that this makes it a lot easier to cache because all images are the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org