You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/10 22:36:20 UTC
Re: Review Request 54793: Prevented task launches that reuse
unreachable task IDs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54793/
-----------------------------------------------------------
(Updated Jan. 10, 2017, 10:36 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Unbreak test.
Bugs: MESOS-6805
https://issues.apache.org/jira/browse/MESOS-6805
Repository: mesos
Description
-------
The master keeps an in-memory cache of task IDs that have recently been
marked unreachable. The master now consults this cache to reject task
launch attempts that reuse one of these recently unreachable task IDs
(such tasks are not terminal and may resume running in the future). This
check is not complete (we won't detect all cases in which unreachable
task IDs are reused), but preventing this from happening in the common
case seems worth doing. See MESOS-6785 for details.
Diffs (updated)
-----
src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
Diff: https://reviews.apache.org/r/54793/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 54793: Prevented task launches that reuse
unreachable task IDs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54793/#review161167
-----------------------------------------------------------
src/tests/partition_tests.cpp (line 3384)
<https://reviews.apache.org/r/54793/#comment232404>
Can you move this to master_validation_tests.cpp to be closer to other validation tests?
- Vinod Kone
On Jan. 10, 2017, 10:36 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54793/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 10:36 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6805
> https://issues.apache.org/jira/browse/MESOS-6805
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master keeps an in-memory cache of task IDs that have recently been
> marked unreachable. The master now consults this cache to reject task
> launch attempts that reuse one of these recently unreachable task IDs
> (such tasks are not terminal and may resume running in the future). This
> check is not complete (we won't detect all cases in which unreachable
> task IDs are reused), but preventing this from happening in the common
> case seems worth doing. See MESOS-6785 for details.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
> src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
>
> Diff: https://reviews.apache.org/r/54793/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54793: Prevented task launches that reuse
unreachable task IDs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54793/#review162738
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 13, 2017, 12:42 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54793/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 12:42 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6805
> https://issues.apache.org/jira/browse/MESOS-6805
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master keeps an in-memory cache of task IDs that have recently been
> marked unreachable. The master now consults this cache to reject task
> launch attempts that reuse one of these recently unreachable task IDs
> (such tasks are not terminal and may resume running in the future). This
> check is not complete (we won't detect all cases in which unreachable
> task IDs are reused), but preventing this from happening in the common
> case seems worth doing. See MESOS-6785 for details.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
> src/tests/master_validation_tests.cpp e5d55e03648cb218d42adc594d6fa7d40ea9bcbb
>
> Diff: https://reviews.apache.org/r/54793/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54793: Prevented task launches that reuse
unreachable task IDs.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54793/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 12:42 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Address review comments.
Bugs: MESOS-6805
https://issues.apache.org/jira/browse/MESOS-6805
Repository: mesos
Description
-------
The master keeps an in-memory cache of task IDs that have recently been
marked unreachable. The master now consults this cache to reject task
launch attempts that reuse one of these recently unreachable task IDs
(such tasks are not terminal and may resume running in the future). This
check is not complete (we won't detect all cases in which unreachable
task IDs are reused), but preventing this from happening in the common
case seems worth doing. See MESOS-6785 for details.
Diffs (updated)
-----
src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
src/tests/master_validation_tests.cpp e5d55e03648cb218d42adc594d6fa7d40ea9bcbb
Diff: https://reviews.apache.org/r/54793/diff/
Testing
-------
`make check`
Thanks,
Neil Conway