You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/13 00:39:25 UTC
[GitHub] [incubator-superset] eugeniamz opened a new issue #9130: Box plot
does not filter in dashboard
eugeniamz opened a new issue #9130: Box plot does not filter in dashboard
URL: https://github.com/apache/incubator-superset/issues/9130
When applying filters in the dashboard the box plot does not filter, not even when force refresh.
However, the filter does apply when select Edit Dashboard.
### Expected results
When applying filters in the filter box, box plot should also filter.
### Actual results
When applying filters all the charts get filter, except the box plot; but if you click Edit Dashboard the box plot gets updated.
#### Screenshots
If applicable, add screenshots to help explain your problem.
#### How to reproduce the bug
1. Go to "World Bank's Data" dashboard
2. Select a region in Filter
3. See Box Plot does not get updated
4. Force Refresh in Box Plot
5. See Box Plot does not get updated
6. Edit Dashboard
7. Box Plot get updated
### Environment
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
I am using Superset version installed in Preset Alpha.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] elaragon commented on issue #9130: Box plot
does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
elaragon commented on issue #9130: Box plot does not filter in dashboard
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-598278330
I am experiencing the exact same problem, surprisingly, I just found that box plots refresh when:
- zooming in/out in the web browser.
- clicking on "Explore Chart" and then returning to the dashboard
I hope this helps to fix this bug soon 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eugeniamz removed a comment on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
eugeniamz removed a comment on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-620687917
🏷️ #bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] gtg472b edited a comment on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
gtg472b edited a comment on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-687927942
> I am experiencing the exact same problem, surprisingly, I just found that box plots refresh when:
>
> * zooming in/out in the web browser.
> * clicking on "Explore Chart" and then returning to the dashboard
>
> I hope this helps to fix this bug soon 🙏
This is exactly what I'm noticing too. Spent over an hour thinking it was something weird with the data causing a problem. Did you find a fix @elaragon?
I've also noticed that changing the browser window size will also force an update, so this must be on the javascript side of things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-688865641
Sounds good 👍 please feel free to reach out on Slack if/when you start working on it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-688637416
@gtg472b we have started introducing ECharts as the new official chart library as part of [SIP-50](https://github.com/apache/incubator-superset/issues/10418), with Pie chart currently being migrated: https://github.com/apache-superset/superset-ui/pull/772. The plan is to migrate Boxplot to ECharts, too, but I haven't gotten around to doing it yet. If someone wants to take the lead on migrating Boxplot, I'd be happy to collaborate. Check the ECharts gallery for example Boxplot charts: https://echarts.apache.org/examples/en/index.html#chart-type-boxplot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-667729549
Re-opening until we get clear confirmation that this is actually fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] gtg472b edited a comment on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
gtg472b edited a comment on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-687927942
> I am experiencing the exact same problem, surprisingly, I just found that box plots refresh when:
>
> * zooming in/out in the web browser.
> * clicking on "Explore Chart" and then returning to the dashboard
>
> I hope this helps to fix this bug soon 🙏
This is exactly what I'm noticing too. Spent over an hour thinking it was something weird with the data causing a problem. Did you find a fix @elaragon?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] carstenkolve commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
carstenkolve commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-634130687
This might be related (or a separate issues), but when editing a chart of type 'box plot', I find that any updated in the 'Group by' field of the 'Query' section are only being reflected when I 'run query' and reload the browser page; the auto-update behaviour I see with the other viz types does not seem to work here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] gtg472b commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
gtg472b commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-687927942
> I am experiencing the exact same problem, surprisingly, I just found that box plots refresh when:
>
> * zooming in/out in the web browser.
> * clicking on "Explore Chart" and then returning to the dashboard
>
> I hope this helps to fix this bug soon 🙏
This is exactly what I'm noticing too. Spent over an hour thinking it was something weird with the data causing a problem. Did you find a fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro closed issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
villebro closed issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] gtg472b commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
gtg472b commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-687927598
I'm still having this issue, any updates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] gtg472b commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
gtg472b commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-688445655
OK if anyone is just dying for a quick workaround (that's ugly as hell):
```diff --git a/superset-frontend/node_modules/@superset-ui/preset-chart-xy/esm/BoxPlot/legacy/transformProps.js b/superset-frontend/node_modules/@superset-ui/preset-chart-xy/esm/BoxPlot/legacy/transformProps.js
index c3839f46..10d2822e 100644
--- a/superset-frontend/node_modules/@superset-ui/preset-chart-xy/esm/BoxPlot/legacy/transformProps.js
+++ b/superset-frontend/node_modules/@superset-ui/preset-chart-xy/esm/BoxPlot/legacy/transformProps.js
@@ -21,7 +21,10 @@ exports.default = transformProps;
* specific language governing permissions and limitations
* under the License.
*/
+var widthToggleValue = 1;
function transformProps(chartProps) {
+ chartProps.width += widthToggleValue;
+ widthToggleValue *= -1;
const {
width,
height,
```
This forces a resize event which causes the Box Plot to actually update on-screen. The toggling seems important (it didn't trigger with just always subtracting one). Plus, I think it might minimize the odds of runaway chart resizing.
I give up trying to find the root cause, and this will work well enough for me. I tried tracing it and can't find what's missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] gtg472b removed a comment on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
gtg472b removed a comment on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-687927598
I'm still having this issue, any updates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] gtg472b commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
gtg472b commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-688861021
Thanks for the info @villebro . I know a lot of these visualizations are being deprecated. I just needed to get that Box Plot to work for now, so it'll hold me over till something replaces it. I've made a lot of mild tweaks to several of the visualizations but it appears the project (sensibly) isn't accepting PRs on any of the deprecated ones. I started looking at building a plugin last night, but...the new Superset code deleted my custom Markup visualizations (I added the ability to reference data via Jinja as per #6771). So, if I start on a plugin, that'll be the one I work on first. If it goes well then I will try to look at these Echart ones!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
stale[bot] closed issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eugeniamz commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
eugeniamz commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-620687917
🏷️ #bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9130: Box plot does not filter in dashboard
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9130:
URL: https://github.com/apache/incubator-superset/issues/9130#issuecomment-663874154
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org