You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/09 07:58:20 UTC
[jira] [Commented] (CB-11683) Cordova-Android fails to properly add
the source of a custom plugin if its source-file.src points to a directory
and plugin is being installed in --link mode
[ https://issues.apache.org/jira/browse/CB-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413152#comment-15413152 ]
ASF GitHub Bot commented on CB-11683:
-------------------------------------
GitHub user sprzedamsanki opened a pull request:
https://github.com/apache/cordova-android/pull/322
CB-11683 android: Fixed linking to directories
Fixed bug described in CB-11683.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sprzedamsanki/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit 19eec150161872541d9a08401ff83e2528a36208
Author: Szymon Drosdzol <sd...@insert.com.pl>
Date: 2016-08-09T07:18:37Z
CB-11683 android: Fixed linking to directories during plugin installation.
----
> Cordova-Android fails to properly add the source of a custom plugin if its source-file.src points to a directory and plugin is being installed in --link mode
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-11683
> URL: https://issues.apache.org/jira/browse/CB-11683
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 3.5.0
> Environment: Windows 10
> Reporter: Szymon Drosdzol
> Priority: Minor
>
> I have cerated a custom plugin. In my plugin.xml I've added java sources directory with the following XML tag:
> {{<source-file src="src/com/thisisdir/" target-dir="src/com/" />}}
> Next I tried to install that plugin using the following command:
> {{cordova plugin add ..\AuthenticatorPlugin --link}}
> Unfortunatetly that only creates a useless 0-byte file in the destination folder instead of proper link.
> This resembles behaviour of Windows' mklink command, which does exactly this when trying to create the link to the directory without the /D parameter. This is clearly bad design. The command failed to do its job but exited normally instead of presenting any error message. Cordova shoudln't replicate that behaviour and handle folder linking on its own. Therefore we should either:
> * fail the task on attempts to link a directory,
> * handle directory linking properly.
> I think the second option is way better :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org