[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5067: Update rate limiter when table config updated on controller (Part 2)

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #5067: Update rate limiter when table config updated on controller (Part 2)
URL: https://github.com/apache/incubator-pinot/pull/5067#discussion_r386759996
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -1720,6 +1726,41 @@ private void sendSegmentRefreshMessage(String offlineTableName, String segmentNa
     }
   }
 
+  private void sendUpdateQueryQuotaMessage(TableConfig tableConfig) {
+    QuotaConfig quotaConfig = tableConfig.getQuotaConfig();
 
 Review comment:
   If the original table config had query quota but it has been removed, don't you want to send the message?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org