You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by da...@apache.org on 2008/02/22 11:58:18 UTC

svn commit: r630150 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/CreateRoleConstantAction.java

Author: dag
Date: Fri Feb 22 02:58:15 2008
New Revision: 630150

URL: http://svn.apache.org/viewvc?rev=630150&view=rev
Log:
DERBY-3173 SQL roles: add catalog support

Bug fix: Moved transaction start up to before the first dictionary access.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/CreateRoleConstantAction.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/CreateRoleConstantAction.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/CreateRoleConstantAction.java?rev=630150&r1=630149&r2=630150&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/CreateRoleConstantAction.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/CreateRoleConstantAction.java Fri Feb 22 02:58:15 2008
@@ -81,6 +81,8 @@
         //
         final String currentAuthId = lcc.getAuthorizationId();
 
+        dd.startWriting(lcc);
+
         //
         // Check if this role already exists. If it does, throw.
         //
@@ -105,7 +107,6 @@
             true,         // with admin option
             true);        // is definition
 
-        dd.startWriting(lcc);
         dd.addDescriptor(rd,
                          null,  // parent
                          DataDictionary.SYSROLES_CATALOG_NUM,