You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/10/18 14:43:20 UTC
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/
-----------------------------------------------------------
(Updated Oct. 18, 2013, 12:43 p.m.)
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4493
https://issues.apache.org/jira/browse/CLOUDSTACK-4493
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
Changing the response object of register and list ssh keypairs APIs
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
Diff: https://reviews.apache.org/r/14305/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On Oct. 19, 2013, 4:42 p.m., Koushik Das wrote:
> > api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java, line 28
> > <https://reviews.apache.org/r/14305/diff/2/?file=366343#file366343line28>
> >
> > Why this is changed to protected?
these are made protected so that they are used in the derived class CreateSSHKeypair response.
SSHkeypairResponse is base class (where name, fingerprint are defined as protected)
CreateSSHkeypairResponse is derived class (where name, fingerprint are used from base class)
If they are defined as private we cannot use them in derived class.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27218
-----------------------------------------------------------
On Oct. 18, 2013, 12:43 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14305/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 12:43 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4493
> https://issues.apache.org/jira/browse/CLOUDSTACK-4493
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
> Changing the response object of register and list ssh keypairs APIs
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
> api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
>
> Diff: https://reviews.apache.org/r/14305/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27218
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java
<https://reviews.apache.org/r/14305/#comment52933>
Why this is changed to protected?
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java
<https://reviews.apache.org/r/14305/#comment52934>
Protected? This is not required
- Koushik Das
On Oct. 18, 2013, 12:43 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14305/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 12:43 p.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4493
> https://issues.apache.org/jira/browse/CLOUDSTACK-4493
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
> Changing the response object of register and list ssh keypairs APIs
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
> api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
>
> Diff: https://reviews.apache.org/r/14305/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27274
-----------------------------------------------------------
Commit f9731144cda4d7982cc4be1e60c1e4aa3b3ca2e2 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f973114 ]
CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) Changing the response object of register and list ssh keypairs APIs
Signed-off-by: Koushik Das <ko...@apache.org>
- ASF Subversion and Git Services
On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14305/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 5:14 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4493
> https://issues.apache.org/jira/browse/CLOUDSTACK-4493
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
> Changing the response object of register and list ssh keypairs APIs
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
> api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
>
> Diff: https://reviews.apache.org/r/14305/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27276
-----------------------------------------------------------
Commit 54e365d00b5ae504c59c025b37387b9c9d166422 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=54e365d ]
CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) Changing the response object of register and list ssh keypairs APIs
Signed-off-by: Koushik Das <ko...@apache.org>
Conflicts:
api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java
- ASF Subversion and Git Services
On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14305/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 5:14 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4493
> https://issues.apache.org/jira/browse/CLOUDSTACK-4493
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
> Changing the response object of register and list ssh keypairs APIs
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
> api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
>
> Diff: https://reviews.apache.org/r/14305/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27250
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14305/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 5:14 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4493
> https://issues.apache.org/jira/browse/CLOUDSTACK-4493
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
> Changing the response object of register and list ssh keypairs APIs
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
> api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
>
> Diff: https://reviews.apache.org/r/14305/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 5:14 a.m.)
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4493
https://issues.apache.org/jira/browse/CLOUDSTACK-4493
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
Changing the response object of register and list ssh keypairs APIs
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
Diff: https://reviews.apache.org/r/14305/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 5:13 a.m.)
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4493
https://issues.apache.org/jira/browse/CLOUDSTACK-4493
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
Changing the response object of register and list ssh keypairs APIs
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
Diff: https://reviews.apache.org/r/14305/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc
contains wrong API response (private key)
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 5:11 a.m.)
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4493
https://issues.apache.org/jira/browse/CLOUDSTACK-4493
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
Changing the response object of register and list ssh keypairs APIs
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 56bec7e
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853
server/src/com/cloud/api/query/vo/TemplateJoinVO.java 618b813
Diff: https://reviews.apache.org/r/14305/diff/
Testing
-------
Thanks,
Harikrishna Patnala