[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

[d2r <gi...@git.apache.org>]

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/250#discussion_r41551583
  
    --- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
    @@ -108,7 +108,15 @@
          */
         public static final String STORM_MESSAGING_NETTY_AUTHENTICATION = "storm.messaging.netty.authentication";
         public static final Object STORM_MESSAGING_NETTY_AUTHENTICATION_SCHEMA = Boolean.class;
    -
    +    
    +    /**
    +     * Netty based messaging: A quality of protection (qop) value is one of "auth" - authentication only, 
    +     * "auth-int" - authentication plus integrity protection, "auth-conf" - authentication plus integrity and confidentiality protection.
    +     * The default qop is "auth".
    +     */
    +    public static final String STORM_MESSAGING_NETTY_PROTECTION = "storm.messaging.netty.protection";
    +    public static final Object STORM_MESSAGING_NETTY_PROTECTION_SCHEMA = String.class;
    --- End diff --
    
    * Is this config intended to be a cluster-wide setting or could it be different for each topology?
    * It would be nice to validate the setting is one of the accepted values beyond being a string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---