You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/10/02 19:34:04 UTC
Re: Review Request 71486: Added `allocated` flag to the
`Allocator::recoverResources()` method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71486/#review218026
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/allocator/allocator.hpp
Line 380 (original), 380 (patched)
<https://reviews.apache.org/r/71486/#comment305488>
For the uninformed, we need to be specific about are allocated resource, how about:
```
... or allocated resources (i.e. resources used for launching tasks, NOT including unused reservations) that are ....
```
src/master/allocator/mesos/allocator.hpp
Lines 152 (patched)
<https://reviews.apache.org/r/71486/#comment305489>
how about "isAllocated"?
- Meng Zhu
On Sept. 27, 2019, 5:59 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71486/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2019, 5:59 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch extends the signature of `recoverResources()` with a flag
> indicating wheteher the resources being recovered were actaully
> allocated to a framework, or only offered.
>
> This is a prerequisite for tracking quota consumption in the allocator.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 2bab53ab5fb25931a724c20a039e1301983ba574
> src/master/allocator/mesos/allocator.hpp 6921581745bf876ee42bcfb62b59245f23fcbf47
> src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24
> src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc
> src/master/master.cpp 65994aa72ec4bfefdb09b88a62db910727bb0897
> src/tests/allocator.hpp 01e6d2ce3d0655ad408f605c7be84cd7c0f0d479
> src/tests/hierarchical_allocator_benchmarks.cpp ede116989fe64893f5da56347aab52c6f445e9dc
> src/tests/hierarchical_allocator_tests.cpp a13eb017f7a93ee67c8426e4150858a547175ed6
> src/tests/master_allocator_tests.cpp e9607577c57c4ae36133a649667b5a416ba9dece
> src/tests/slave_recovery_tests.cpp b23162d68e2aeaa7b1f1c0d74804bbef5cb1f045
>
>
> Diff: https://reviews.apache.org/r/71486/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71486: Added `isAllocated` flag to the
`Allocator::recoverResources()` method.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
> On Oct. 2, 2019, 7:34 p.m., Meng Zhu wrote:
> > include/mesos/allocator/allocator.hpp
> > Line 380 (original), 380 (patched)
> > <https://reviews.apache.org/r/71486/diff/3/?file=2167250#file2167250line380>
> >
> > For the uninformed, we need to be specific about are allocated resource, how about:
> >
> > ```
> > ... or allocated resources (i.e. resources used for launching tasks, NOT including unused reservations) that are ....
> > ```
Not sure that this is a right place to mention reservations (`recoverResources()` had nothing to do with them in the past, and I'm not changing this).
After all, resource being reserved/unreserved is orthogonal to resource being available/offered/allocated, isnt't it?
Added `resources used for launching tasks` clarification, though; this makes perfect sense.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71486/#review218026
-----------------------------------------------------------
On Oct. 4, 2019, 6:06 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71486/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2019, 6:06 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch extends the signature of `recoverResources()` with a flag
> indicating wheteher the resources being recovered were actaully
> allocated to a framework, or only offered.
>
> This is a prerequisite for tracking quota consumption in the allocator.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 2bab53ab5fb25931a724c20a039e1301983ba574
> src/master/allocator/mesos/allocator.hpp 6921581745bf876ee42bcfb62b59245f23fcbf47
> src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24
> src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc
> src/master/master.cpp 65994aa72ec4bfefdb09b88a62db910727bb0897
> src/tests/allocator.hpp 01e6d2ce3d0655ad408f605c7be84cd7c0f0d479
> src/tests/hierarchical_allocator_benchmarks.cpp ede116989fe64893f5da56347aab52c6f445e9dc
> src/tests/hierarchical_allocator_tests.cpp 56c8caf65d8174e5b1560f2b1aaef067337be653
> src/tests/master_allocator_tests.cpp e9607577c57c4ae36133a649667b5a416ba9dece
> src/tests/slave_recovery_tests.cpp b23162d68e2aeaa7b1f1c0d74804bbef5cb1f045
>
>
> Diff: https://reviews.apache.org/r/71486/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>