You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/05/11 16:32:01 UTC
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15902
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Exhaustive tests fail, so reverting this.
This reverts commit c32849a3912a6fe295e74269bf0c1f350962d57f.
Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
---
M testdata/datasets/functional/functional_schema_template.sql
M testdata/workloads/functional-query/queries/QueryTest/insert-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/insert_bad_expr.test
M testdata/workloads/functional-query/queries/QueryTest/insert_null.test
M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test
M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test
M testdata/workloads/functional-query/queries/QueryTest/load.test
M testdata/workloads/functional-query/queries/QueryTest/show.test
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_mt_dop.py
M tests/query_test/test_insert.py
M tests/query_test/test_mt_dop.py
13 files changed, 266 insertions(+), 147 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/15902/1
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15902 )
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5807/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 16:32:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/15902 )
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Abandoned
Already synced up, and the fix for IMPALA-9680 went in, so this can be abandoned.
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15902 )
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Patch Set 1: Code-Review-1
Tamas just submitted a patch to fix whatever went wrong by IMPALA-8980. Can we give it a chance and let's see if this fixes the build?
Btw, if you go for a revert, these are the follow up changes that went in for IMPALA-8980:
https://gerrit.cloudera.org/#/c/15766/
https://gerrit.cloudera.org/#/c/15816/
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 05:13:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15902 )
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 16:35:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15902 )
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15902/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/15902/1/tests/common/impala_test_suite.py@784
PS1, Line 784: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/15902/1/tests/common/impala_test_suite.py@789
PS1, Line 789: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/15902/1/tests/common/impala_test_suite.py@927
PS1, Line 927: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/15902/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
http://gerrit.cloudera.org:8080/#/c/15902/1/tests/query_test/test_mt_dop.py@179
PS1, Line 179:
flake8: W391 blank line at end of file
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 16:33:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15902 )
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 22:15:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15902 )
Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6026/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9acba85b1082502b2bc62acc76116de5750d30
Gerrit-Change-Number: 15902
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 17:25:11 +0000
Gerrit-HasComments: No