You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/03/17 20:53:26 UTC
Review Request 19319: Fix "from deserialization" in comments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19319/
-----------------------------------------------------------
Review request for hive and Gunther Hagleitner.
Bugs: HIVE-6681
https://issues.apache.org/jira/browse/HIVE-6681
Repository: hive-git
Description
-------
Fix "from deserialization" comments.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 56d68f5
contrib/src/test/results/clientpositive/fileformat_base64.q.out 3489270
hbase-handler/src/test/results/positive/hbase_stats.q.out f05b8ff
hbase-handler/src/test/results/positive/hbase_stats2.q.out f05b8ff
hbase-handler/src/test/results/positive/hbase_stats3.q.out 0467f8a
hbase-handler/src/test/results/positive/hbase_stats_empty_partition.q.out 6987f64
itests/test-serde/src/main/java/org/apache/hadoop/hive/serde2/TestSerDe.java 23e67e3
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 06c216f
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java cee1637
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 42df435
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 9a6e336
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 45ad315
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java de04cca
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 73603ab
ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java b569ed0
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 98c511e
ql/src/test/results/clientnegative/alter_partition_coltype_2columns.q.out ed36d5d
ql/src/test/results/clientnegative/alter_partition_coltype_invalidcolname.q.out c6913b9
ql/src/test/results/clientnegative/alter_partition_coltype_invalidtype.q.out 740982c
ql/src/test/results/clientnegative/alter_view_as_select_with_partition.q.out e4c2071
ql/src/test/results/clientnegative/desc_failure2.q.out a2e3b36
ql/src/test/results/clientnegative/protectmode_part_no_drop.q.out 2f0fabc
ql/src/test/results/clientnegative/protectmode_tbl2.q.out e44ae1a
ql/src/test/results/clientnegative/protectmode_tbl3.q.out b05a371
ql/src/test/results/clientnegative/protectmode_tbl4.q.out 77c2d0e
ql/src/test/results/clientnegative/protectmode_tbl5.q.out f078c91
ql/src/test/results/clientnegative/protectmode_tbl_no_drop.q.out d451fc7
ql/src/test/results/clientnegative/stats_partialscan_autogether.q.out cee6b53
ql/src/test/results/clientpositive/alter1.q.out 2b5ddba
ql/src/test/results/clientpositive/alter2.q.out 54fa503
ql/src/test/results/clientpositive/alter3.q.out f13e0e4
ql/src/test/results/clientpositive/alter4.q.out 001b922
ql/src/test/results/clientpositive/alter5.q.out d36d40b
ql/src/test/results/clientpositive/alter_merge_2.q.out 12c3b09
ql/src/test/results/clientpositive/alter_merge_stats.q.out 0dc693d
ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table.q.out 583fc54
ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table2.q.out b79a4d4
ql/src/test/results/clientpositive/alter_partition_clusterby_sortby.q.out 18dd11c
ql/src/test/results/clientpositive/alter_partition_coltype.q.out 30d53cc
ql/src/test/results/clientpositive/alter_partition_format_loc.q.out eab0cd8
ql/src/test/results/clientpositive/alter_skewed_table.q.out 70e00f4
ql/src/test/results/clientpositive/alter_table_not_sorted.q.out 07fcb32
ql/src/test/results/clientpositive/alter_table_serde.q.out 2c25f67
ql/src/test/results/clientpositive/alter_table_serde2.q.out 347512c
ql/src/test/results/clientpositive/alter_view_as_select.q.out 686ceb3
ql/src/test/results/clientpositive/alter_view_rename.q.out 0aadc34
ql/src/test/results/clientpositive/authorization_7.q.out c9468be
ql/src/test/results/clientpositive/authorization_8.q.out 484f179
ql/src/test/results/clientpositive/autogen_colalias.q.out 5fe1543
ql/src/test/results/clientpositive/ba_table1.q.out 0877dd9
ql/src/test/results/clientpositive/ba_table2.q.out 4174287
ql/src/test/results/clientpositive/ba_table_union.q.out 8846a01
ql/src/test/results/clientpositive/binary_table_bincolserde.q.out bb3c296
ql/src/test/results/clientpositive/binary_table_colserde.q.out a8b195f
ql/src/test/results/clientpositive/bucket4.q.out 3f21a5a
ql/src/test/results/clientpositive/bucket5.q.out c2fc368
ql/src/test/results/clientpositive/bucket_groupby.q.out 10dcb6e
ql/src/test/results/clientpositive/bucketmapjoin7.q.out dfa1fb2
ql/src/test/results/clientpositive/char_nested_types.q.out 8a01d34
ql/src/test/results/clientpositive/columnarserde_create_shortcut.q.out 0a45736
ql/src/test/results/clientpositive/combine3.q.out 4fb7930
ql/src/test/results/clientpositive/convert_enum_to_string.q.out 3d504c1
ql/src/test/results/clientpositive/create_1.q.out 49e14ad
ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out 17a7bb9
ql/src/test/results/clientpositive/create_default_prop.q.out 21a60f8
ql/src/test/results/clientpositive/create_escape.q.out faba8fd
ql/src/test/results/clientpositive/create_insert_outputformat.q.out 90e1ddd
ql/src/test/results/clientpositive/create_like.q.out 97fdee9
ql/src/test/results/clientpositive/create_like2.q.out 82cb042
ql/src/test/results/clientpositive/create_like_tbl_props.q.out 8e64eab
ql/src/test/results/clientpositive/create_like_view.q.out c56da79
ql/src/test/results/clientpositive/create_nested_type.q.out 6da098b
ql/src/test/results/clientpositive/create_or_replace_view.q.out a72d2ab
ql/src/test/results/clientpositive/create_skewed_table1.q.out d840831
ql/src/test/results/clientpositive/create_view.q.out ddfe85c
ql/src/test/results/clientpositive/create_view_partitioned.q.out ce9abcd
ql/src/test/results/clientpositive/create_view_translate.q.out 7549eae
ql/src/test/results/clientpositive/ctas.q.out 0bda29a
ql/src/test/results/clientpositive/ctas_colname.q.out 3d568ab
ql/src/test/results/clientpositive/ctas_hadoop20.q.out b86a14c
ql/src/test/results/clientpositive/ctas_uses_database_location.q.out 024fa8b
ql/src/test/results/clientpositive/custom_input_output_format.q.out 9dc6480
ql/src/test/results/clientpositive/database.q.out 448f4e9
ql/src/test/results/clientpositive/database_location.q.out e829c63
ql/src/test/results/clientpositive/dbtxnmgr_query5.q.out 4408256
ql/src/test/results/clientpositive/ddltime.q.out 5828d9f
ql/src/test/results/clientpositive/decimal_1.q.out edeebf3
ql/src/test/results/clientpositive/decimal_6.q.out ddb630f
ql/src/test/results/clientpositive/describe_formatted_view_partitioned.q.out 1dacca8
ql/src/test/results/clientpositive/describe_pretty.q.out 8765f66
ql/src/test/results/clientpositive/describe_syntax.q.out e4c4f96
ql/src/test/results/clientpositive/describe_table.q.out e907248
ql/src/test/results/clientpositive/disable_merge_for_bucketing.q.out ddccb58
ql/src/test/results/clientpositive/drop_partitions_filter.q.out b77972c
ql/src/test/results/clientpositive/drop_partitions_filter2.q.out ce32a93
ql/src/test/results/clientpositive/drop_partitions_filter3.q.out c36cb72
ql/src/test/results/clientpositive/drop_partitions_ignore_protection.q.out e567136
ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out 8623f4b
ql/src/test/results/clientpositive/exim_hidden_files.q.out 7513262
ql/src/test/results/clientpositive/fileformat_sequencefile.q.out 82b3667
ql/src/test/results/clientpositive/fileformat_text.q.out efb0ca2
ql/src/test/results/clientpositive/import_exported_table.q.out 35e5637
ql/src/test/results/clientpositive/infer_bucket_sort.q.out fbb8837
ql/src/test/results/clientpositive/infer_bucket_sort_bucketed_table.q.out 8659da5
ql/src/test/results/clientpositive/infer_bucket_sort_convert_join.q.out 36b78fa
ql/src/test/results/clientpositive/infer_bucket_sort_dyn_part.q.out 4cce425
ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 90dfe92
ql/src/test/results/clientpositive/infer_bucket_sort_list_bucket.q.out 839dbab
ql/src/test/results/clientpositive/infer_bucket_sort_map_operators.q.out 2c23c39
ql/src/test/results/clientpositive/infer_bucket_sort_merge.q.out 9ac009e
ql/src/test/results/clientpositive/infer_bucket_sort_multi_insert.q.out 792ecde
ql/src/test/results/clientpositive/infer_bucket_sort_num_buckets.q.out 256fca0
ql/src/test/results/clientpositive/inoutdriver.q.out 3fc01ef
ql/src/test/results/clientpositive/input1.q.out af975f0
ql/src/test/results/clientpositive/input10.q.out abdb2d1
ql/src/test/results/clientpositive/input15.q.out 6008a14
ql/src/test/results/clientpositive/input2.q.out 89ceefe
ql/src/test/results/clientpositive/input3.q.out 7ea0343
ql/src/test/results/clientpositive/input_part10.q.out 1a7ef57
ql/src/test/results/clientpositive/inputddl2.q.out bc40300
ql/src/test/results/clientpositive/inputddl3.q.out 86909c4
ql/src/test/results/clientpositive/inputddl4.q.out 9f17601
ql/src/test/results/clientpositive/inputddl5.q.out 929c5ee
ql/src/test/results/clientpositive/inputddl6.q.out ae0bc12
ql/src/test/results/clientpositive/inputddl7.q.out 7387142
ql/src/test/results/clientpositive/inputddl8.q.out d8e93b8
ql/src/test/results/clientpositive/lb_fs_stats.q.out 5a15684
ql/src/test/results/clientpositive/list_bucket_dml_1.q.out e32b9fe
ql/src/test/results/clientpositive/list_bucket_dml_10.q.out 6c37697
ql/src/test/results/clientpositive/list_bucket_dml_11.q.out 5d844fe
ql/src/test/results/clientpositive/list_bucket_dml_12.q.out 894b6d3
ql/src/test/results/clientpositive/list_bucket_dml_13.q.out 2d21bef
ql/src/test/results/clientpositive/list_bucket_dml_2.q.out 1be44cc
ql/src/test/results/clientpositive/list_bucket_dml_3.q.out 05804d0
ql/src/test/results/clientpositive/list_bucket_dml_4.q.out 30829f0
ql/src/test/results/clientpositive/list_bucket_dml_5.q.out b0a2127
ql/src/test/results/clientpositive/list_bucket_dml_6.q.out cf6c34d
ql/src/test/results/clientpositive/list_bucket_dml_7.q.out 863203f
ql/src/test/results/clientpositive/list_bucket_dml_8.q.out edb4e07
ql/src/test/results/clientpositive/list_bucket_dml_9.q.out 3cab1a5
ql/src/test/results/clientpositive/list_bucket_query_multiskew_1.q.out 5113e96
ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out fd122df
ql/src/test/results/clientpositive/list_bucket_query_multiskew_3.q.out f762eee
ql/src/test/results/clientpositive/list_bucket_query_oneskew_1.q.out 98a1a70
ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 99be253
ql/src/test/results/clientpositive/list_bucket_query_oneskew_3.q.out cefa684
ql/src/test/results/clientpositive/load_dyn_part1.q.out 84ce714
ql/src/test/results/clientpositive/load_dyn_part10.q.out 03be8c2
ql/src/test/results/clientpositive/load_dyn_part11.q.out d3d2792
ql/src/test/results/clientpositive/load_dyn_part12.q.out 9b209f4
ql/src/test/results/clientpositive/load_dyn_part13.q.out db22dd8
ql/src/test/results/clientpositive/load_dyn_part14.q.out 44e836e
ql/src/test/results/clientpositive/load_dyn_part2.q.out 22019c7
ql/src/test/results/clientpositive/load_dyn_part3.q.out 5b08184
ql/src/test/results/clientpositive/load_dyn_part4.q.out 732f123
ql/src/test/results/clientpositive/load_dyn_part5.q.out 0e5f341
ql/src/test/results/clientpositive/load_dyn_part6.q.out d0901b5
ql/src/test/results/clientpositive/load_dyn_part7.q.out f7f4f76
ql/src/test/results/clientpositive/load_dyn_part8.q.out 7c80a96
ql/src/test/results/clientpositive/load_dyn_part9.q.out 2794bcb
ql/src/test/results/clientpositive/load_fs.q.out e77dd68
ql/src/test/results/clientpositive/merge3.q.out 0773c52
ql/src/test/results/clientpositive/multi_sahooks.q.out 14f0eeb
ql/src/test/results/clientpositive/nested_complex.q.out 5c3fdac
ql/src/test/results/clientpositive/nullformat.q.out 7ea1e95
ql/src/test/results/clientpositive/nullformatCTAS.q.out 1c64658
ql/src/test/results/clientpositive/nullformatdir.q.out f052726
ql/src/test/results/clientpositive/orc_create.q.out 4dd0a87
ql/src/test/results/clientpositive/orc_vectorization_ppd.q.out 27d5c29
ql/src/test/results/clientpositive/parallel_orderby.q.out 545f956
ql/src/test/results/clientpositive/parquet_create.q.out d2b98e9
ql/src/test/results/clientpositive/parquet_ctas.q.out 65964fa
ql/src/test/results/clientpositive/parquet_partitioned.q.out 9a798a6
ql/src/test/results/clientpositive/part_inherit_tbl_props.q.out 5ebef1a
ql/src/test/results/clientpositive/part_inherit_tbl_props_empty.q.out d533c8d
ql/src/test/results/clientpositive/part_inherit_tbl_props_with_star.q.out 6892af0
ql/src/test/results/clientpositive/partition_date2.q.out e0f55f4
ql/src/test/results/clientpositive/partition_schema1.q.out aabedb8
ql/src/test/results/clientpositive/protectmode.q.out c31c6cf
ql/src/test/results/clientpositive/protectmode2.q.out 83bcb9b
ql/src/test/results/clientpositive/quotedid_basic.q.out a33574c
ql/src/test/results/clientpositive/quotedid_tblproperty.q.out 153f148
ql/src/test/results/clientpositive/rcfile_bigdata.q.out 455f896
ql/src/test/results/clientpositive/rcfile_columnar.q.out 50ee6d7
ql/src/test/results/clientpositive/rcfile_default_format.q.out 33bf57c
ql/src/test/results/clientpositive/reduce_deduplicate.q.out 42ede17
ql/src/test/results/clientpositive/rename_column.q.out 4de0724
ql/src/test/results/clientpositive/serde_reported_schema.q.out d8a479f
ql/src/test/results/clientpositive/stats0.q.out d951153
ql/src/test/results/clientpositive/stats1.q.out 99b0e60
ql/src/test/results/clientpositive/stats10.q.out e23f8ca
ql/src/test/results/clientpositive/stats11.q.out c3158a7
ql/src/test/results/clientpositive/stats12.q.out 4e0c060
ql/src/test/results/clientpositive/stats13.q.out b30c543
ql/src/test/results/clientpositive/stats14.q.out f05b8ff
ql/src/test/results/clientpositive/stats15.q.out f05b8ff
ql/src/test/results/clientpositive/stats16.q.out 84d564c
ql/src/test/results/clientpositive/stats18.q.out a6eece4
ql/src/test/results/clientpositive/stats19.q.out bcc639a
ql/src/test/results/clientpositive/stats2.q.out 7e157ea
ql/src/test/results/clientpositive/stats20.q.out 30db4a9
ql/src/test/results/clientpositive/stats3.q.out d8a087b
ql/src/test/results/clientpositive/stats4.q.out a91ce77
ql/src/test/results/clientpositive/stats5.q.out 14de4f8
ql/src/test/results/clientpositive/stats6.q.out 74f71ad
ql/src/test/results/clientpositive/stats7.q.out 0fbe98f
ql/src/test/results/clientpositive/stats8.q.out 1bd9427
ql/src/test/results/clientpositive/stats9.q.out 404d588
ql/src/test/results/clientpositive/stats_counter.q.out 40d8656
ql/src/test/results/clientpositive/stats_counter_partitioned.q.out b41b357
ql/src/test/results/clientpositive/stats_empty_partition.q.out 6987f64
ql/src/test/results/clientpositive/stats_invalidation.q.out a9e5e7b
ql/src/test/results/clientpositive/stats_list_bucket.q.out 6a319a0
ql/src/test/results/clientpositive/stats_noscan_1.q.out 990acec
ql/src/test/results/clientpositive/stats_noscan_2.q.out afbc69c
ql/src/test/results/clientpositive/stats_only_null.q.out 5400023
ql/src/test/results/clientpositive/stats_partscan_1.q.out 7cc6e97
ql/src/test/results/clientpositive/stats_partscan_1_23.q.out beebfad
ql/src/test/results/clientpositive/statsfs.q.out ed2192f
ql/src/test/results/clientpositive/tablename_with_select.q.out 81d696a
ql/src/test/results/clientpositive/truncate_column.q.out a352aa0
ql/src/test/results/clientpositive/unicode_notation.q.out b650fa1
ql/src/test/results/clientpositive/union_remove_1.q.out 74d20bc
ql/src/test/results/clientpositive/union_remove_10.q.out 76cc5fc
ql/src/test/results/clientpositive/union_remove_11.q.out 68efb49
ql/src/test/results/clientpositive/union_remove_12.q.out d2dd47c
ql/src/test/results/clientpositive/union_remove_13.q.out fa0849c
ql/src/test/results/clientpositive/union_remove_14.q.out f837dea
ql/src/test/results/clientpositive/union_remove_15.q.out d439ec7
ql/src/test/results/clientpositive/union_remove_16.q.out eeba6a3
ql/src/test/results/clientpositive/union_remove_17.q.out 1fdc4e8
ql/src/test/results/clientpositive/union_remove_18.q.out 04c5e74
ql/src/test/results/clientpositive/union_remove_19.q.out d442585
ql/src/test/results/clientpositive/union_remove_2.q.out b922366
ql/src/test/results/clientpositive/union_remove_20.q.out 9530c90
ql/src/test/results/clientpositive/union_remove_21.q.out f737744
ql/src/test/results/clientpositive/union_remove_22.q.out f095e5b
ql/src/test/results/clientpositive/union_remove_23.q.out 51b8e09
ql/src/test/results/clientpositive/union_remove_24.q.out a54a478
ql/src/test/results/clientpositive/union_remove_3.q.out f7a64cd
ql/src/test/results/clientpositive/union_remove_4.q.out 817856e
ql/src/test/results/clientpositive/union_remove_5.q.out 824d5bb
ql/src/test/results/clientpositive/union_remove_7.q.out 62b7dd5
ql/src/test/results/clientpositive/union_remove_8.q.out 8f0b378
ql/src/test/results/clientpositive/union_remove_9.q.out 28ca8da
ql/src/test/results/clientpositive/updateAccessTime.q.out 2695c8d
ql/src/test/results/clientpositive/varchar_nested_types.q.out 51f0c8a
ql/src/test/results/clientpositive/vectorization_part.q.out 2ac4ddd
ql/src/test/results/clientpositive/vectorization_part_project.q.out 36a45df
ql/src/test/results/clientpositive/vectorized_bucketmapjoin1.q.out 5403204
ql/src/test/results/clientpositive/vectorized_context.q.out 7a2f773
ql/src/test/results/clientpositive/vectorized_rcfile_columnar.q.out 1000b36
ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out 70c654c
ql/src/test/results/compiler/plan/case_sensitivity.q.xml 02c3d06
ql/src/test/results/compiler/plan/cast1.q.xml 8e254aa
ql/src/test/results/compiler/plan/groupby1.q.xml e257d4b
ql/src/test/results/compiler/plan/groupby2.q.xml 6041e9e
ql/src/test/results/compiler/plan/groupby3.q.xml b2c70b1
ql/src/test/results/compiler/plan/groupby4.q.xml cf7b100
ql/src/test/results/compiler/plan/groupby5.q.xml 8f022b3
ql/src/test/results/compiler/plan/groupby6.q.xml ff372d3
ql/src/test/results/compiler/plan/input1.q.xml 4365afe
ql/src/test/results/compiler/plan/input2.q.xml 5b17981
ql/src/test/results/compiler/plan/input20.q.xml 912e9e3
ql/src/test/results/compiler/plan/input3.q.xml 4f2eafe
ql/src/test/results/compiler/plan/input4.q.xml 47fe9ff
ql/src/test/results/compiler/plan/input5.q.xml 31b599c
ql/src/test/results/compiler/plan/input6.q.xml d27978c
ql/src/test/results/compiler/plan/input7.q.xml 0889df4
ql/src/test/results/compiler/plan/input8.q.xml e2c9439
ql/src/test/results/compiler/plan/input9.q.xml c4fcee8
ql/src/test/results/compiler/plan/input_part1.q.xml 95075fe
ql/src/test/results/compiler/plan/input_testsequencefile.q.xml 9d35abe
ql/src/test/results/compiler/plan/input_testxpath.q.xml 37ddde3
ql/src/test/results/compiler/plan/input_testxpath2.q.xml 125cbfa
ql/src/test/results/compiler/plan/join1.q.xml 12b01ce
ql/src/test/results/compiler/plan/join2.q.xml ed5bbb8
ql/src/test/results/compiler/plan/join3.q.xml 5437afa
ql/src/test/results/compiler/plan/join4.q.xml aa69ada
ql/src/test/results/compiler/plan/join5.q.xml ef0c69d
ql/src/test/results/compiler/plan/join6.q.xml da528f5
ql/src/test/results/compiler/plan/join7.q.xml fcacc6d
ql/src/test/results/compiler/plan/join8.q.xml c7591a4
ql/src/test/results/compiler/plan/sample1.q.xml 2021f69
ql/src/test/results/compiler/plan/sample2.q.xml c8998f4
ql/src/test/results/compiler/plan/sample3.q.xml f12a43b
ql/src/test/results/compiler/plan/sample4.q.xml c8998f4
ql/src/test/results/compiler/plan/sample5.q.xml aaee234
ql/src/test/results/compiler/plan/sample6.q.xml 3dc8a84
ql/src/test/results/compiler/plan/sample7.q.xml 9bfe9a8
ql/src/test/results/compiler/plan/subq.q.xml 38366e6
ql/src/test/results/compiler/plan/udf1.q.xml ec0e2e1
ql/src/test/results/compiler/plan/udf4.q.xml 207e5b0
ql/src/test/results/compiler/plan/udf6.q.xml cea326e
ql/src/test/results/compiler/plan/udf_case.q.xml c155bb0
ql/src/test/results/compiler/plan/udf_when.q.xml 0bc4b7f
ql/src/test/results/compiler/plan/union.q.xml 46351be
serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 4b9a4f9
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java d972321
Diff: https://reviews.apache.org/r/19319/diff/
Testing
-------
.q.out updates
Thanks,
Ashutosh Chauhan