You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/03 16:55:15 UTC
[GitHub] [pulsar] kaushik-develop opened a new pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
kaushik-develop opened a new pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918
- fix a race between accumulating/reporting/retrieving local-usage RG stats
- fix a bug in calling quota-calculator from the local-usage aggregator
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Fixes a couple of bugs found during testing of publish rate limiter for resource groups
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ X] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
mvn test -Dtest=org.apache.pulsar.broker.resourcegroup.ResourceGroupUsageAggregationTest -pl pulsar-broker
mvn test -Dtest=org.apache.pulsar.broker.resourcegroup.ResourceQuotaCalculatorImplTest -pl pulsar-broker
mvn test -Dtest=org.apache.pulsar.broker.resourcegroup.RGUsageMTAggrWaitForAllMesgsTest -pl pulsar-broker
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs? no
- [ ] doc-required
(If you need help on updating docs, create a doc issue)
- [ ] no-need-doc
(Please explain why)
- [ ] doc
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng merged pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
Posted by GitBox <gi...@apache.org>.
jerrypeng merged pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaushik-develop commented on pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918#issuecomment-912876535
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaushik-develop commented on pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918#issuecomment-912712799
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaushik-develop commented on pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918#issuecomment-912781288
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaushik-develop commented on pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918#issuecomment-914578488
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaushik-develop commented on pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918#issuecomment-912768749
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaushik-develop commented on pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:
Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #11918:
URL: https://github.com/apache/pulsar/pull/11918#issuecomment-912872831
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org