[jira] [Commented] (HDFS-12949) Fix findbugs warning in ImageWriter.java

["Akira Ajisaka (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-12949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298528#comment-16298528 ] 

Akira Ajisaka commented on HDFS-12949:
--------------------------------------

{code}
    try {
      dirsTmp = File.createTempFile("fsimg_dir", null);
      dirsTmp.deleteOnExit();
      dirsTmpStream = new FileOutputStream(dirsTmp);
      dirs = beginSection(dirsTmpStream);
    } catch (IOException e) {
      IOUtils.cleanupWithLogger(null, raw, dirsTmpStream);
      throw e;
    }
{code}
{{IOUtils.cleanupWithLogger(null, raw, dirsTmpStream)}} actually closes {{dirsTmpStream}} on checked exception, so we can ignore this.

> Fix findbugs warning in ImageWriter.java
> ----------------------------------------
>
>                 Key: HDFS-12949
>                 URL: https://issues.apache.org/jira/browse/HDFS-12949
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>
> There are 1 findbugs warning in hadoop-fs2img module.
> {noformat}
> OBL	new org.apache.hadoop.hdfs.server.namenode.ImageWriter(ImageWriter$Options) may fail to clean up java.io.OutputStream on checked exception
> Bug type OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE (click for details) 
> In class org.apache.hadoop.hdfs.server.namenode.ImageWriter
> In method new org.apache.hadoop.hdfs.server.namenode.ImageWriter(ImageWriter$Options)
> Reference type java.io.OutputStream
> 1 instances of obligation remaining
> Obligation to clean up resource created at ImageWriter.java:[line 184] is not discharged
> Path continues at ImageWriter.java:[line 185]
> Path continues at ImageWriter.java:[line 186]
> Path continues at ImageWriter.java:[line 187]
> Path continues at ImageWriter.java:[line 188]
> Remaining obligations: {OutputStream x 1}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org