You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/07 21:19:56 UTC

[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...

GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/364

    Fix another findbugs high priority warning

    JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High
    Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int)
    
    This now correctly compares strings

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #364
    
----
commit 5a3e3ff57f87dde0ec5c87fba0ebf3649aafe527
Author: Rafael da Fonseca <rs...@gmail.com>
Date:   2015-06-07T19:18:11Z

    Fix another findbugs high priority warning
    JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High
    Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int)
    
    This now correctly compares strings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/364#issuecomment-109890819
  
    LGTM. asfbot looks like known issue with java version in a unrelated module.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/364


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---