You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/09 03:55:37 UTC
[GitHub] [incubator-doris] CrazyJugger opened a new pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
CrazyJugger opened a new pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866
doris web data-model-rollup.html used 36 bytes but used 32 byte as prefix index
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#issuecomment-729505041
> @caiconghui
> but i receive another committer suggestion that ,it's a indeed wrong
> [https://github.com/apache/incubator-doris/issues/4865](url)
> sorry it's first that i commit，
> I will be more careful next time
You'r welcome. could you please modify the example content, and submit your PR again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui edited a comment on pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
caiconghui edited a comment on pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#issuecomment-729505041
> @caiconghui
> but i receive another committer suggestion that ,it's a indeed wrong
> [https://github.com/apache/incubator-doris/issues/4865](url)
> sorry it's first that i commit，
> I will be more careful next time
@CrazyJugger
You'r welcome. could you please modify the example content, and submit your PR again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] CrazyJugger commented on pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
CrazyJugger commented on pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#issuecomment-729513833
@caiconghui ok ~ that i will fix the documen and found another pr to fix
thank you that you solved my question ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#discussion_r525864057
##########
File path: docs/zh-CN/getting-started/data-model-rollup.md
##########
@@ -450,7 +450,7 @@ Doris 会自动命中这个 ROLLUP 表。
而前缀索引，即在排序的基础上，实现的一种根据给定前缀列，快速查询数据的索引方式。
-我们将一行数据的前 **36 个字节** 作为这行数据的前缀索引。当遇到 VARCHAR 类型时，前缀索引会直接截断。我们举例说明：
+我们将一行数据的前 **32 个字节** 作为这行数据的前缀索引。当遇到 VARCHAR 类型时，前缀索引会直接截断。我们举例说明：
1. 以下表结构的前缀索引为 user_id(8Byte) + age(4Bytes) + message(prefix 20 Bytes)。
Review comment:
```suggestion
1. 以下表结构的前缀索引为 user_id(8Byte) + age(4Bytes) + message(prefix 24 Bytes)。
```
##########
File path: docs/zh-CN/getting-started/data-model-rollup.md
##########
@@ -462,7 +462,7 @@ Doris 会自动命中这个 ROLLUP 表。
|max\_dwell\_time|DATETIME|
|min\_dwell\_time|DATETIME|
-2. 以下表结构的前缀索引为 user_name(20 Bytes)。即使没有达到 36 个字节，因为遇到 VARCHAR，所以直接截断，不再往后继续。
+2. 以下表结构的前缀索引为 user_name(20 Bytes)。即使没有达到 32 个字节，因为遇到 VARCHAR，所以直接截断，不再往后继续。
Review comment:
```suggestion
2. 以下表结构的前缀索引为 user_name(20 Bytes)。即使没有达到 36 个字节，因为遇到 VARCHAR，所以直接截断，不再往后继续。
```
##########
File path: docs/zh-CN/getting-started/data-model-rollup.md
##########
@@ -450,7 +450,7 @@ Doris 会自动命中这个 ROLLUP 表。
而前缀索引，即在排序的基础上，实现的一种根据给定前缀列，快速查询数据的索引方式。
-我们将一行数据的前 **36 个字节** 作为这行数据的前缀索引。当遇到 VARCHAR 类型时，前缀索引会直接截断。我们举例说明：
+我们将一行数据的前 **32 个字节** 作为这行数据的前缀索引。当遇到 VARCHAR 类型时，前缀索引会直接截断。我们举例说明：
Review comment:
```suggestion
我们将一行数据的前 **36 个字节** 作为这行数据的前缀索引。当遇到 VARCHAR 类型时，前缀索引会直接截断。我们举例说明：
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#issuecomment-729494596
@CrazyJugger Thank you for your PR. And please create an issue related to this PR firstly. The default shortkey_maxsize_bytes is 36, so there is no need to modify this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#issuecomment-775638851
> @caiconghui ok ~ that i will fix the documen and found another pr to fix
> thank you that you solved my question ~
@CrazyJugger So, This pr is useless, I just close it directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] CrazyJugger commented on pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
CrazyJugger commented on pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#issuecomment-729497405
@caiconghui
but i receive another committer suggestion that ,it's a indeed wrong
[https://github.com/apache/incubator-doris/issues/4865](url)
sorry it's first that i commit，
I will be more careful next time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #4866: fix doris-web document doris use the first 36 bytes as the prefix index
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #4866:
URL: https://github.com/apache/incubator-doris/pull/4866#issuecomment-729501440
> @caiconghui
> but i receive another committer suggestion that ,it's a indeed wrong
> [https://github.com/apache/incubator-doris/issues/4865](url)
> sorry it's first that i commit，
> I will be more careful next time
I am so so sorry, the shortkey_maxsize_bytes is indeed 36. This value was 32 in the version a long time ago, and has now been updated to 36.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org