You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by jo...@apache.org on 2024/11/05 23:15:09 UTC
(jackrabbit-oak) branch OAK-11251 created (now c25c7d74a3)
This is an automated email from the ASF dual-hosted git repository.
joscorbe pushed a change to branch OAK-11251
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git
at c25c7d74a3 OAK-11251: Improve warning in collectFullGC to reduce its noisiness.
This branch includes the following new commits:
new c25c7d74a3 OAK-11251: Improve warning in collectFullGC to reduce its noisiness.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(jackrabbit-oak) 01/01: OAK-11251: Improve warning in collectFullGC to reduce its noisiness.
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
joscorbe pushed a commit to branch OAK-11251
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git
commit c25c7d74a3429b0ec4fcb6875b30675d7a28f091
Author: Jose Cordero <co...@adobe.com>
AuthorDate: Wed Nov 6 00:14:46 2024 +0100
OAK-11251: Improve warning in collectFullGC to reduce its noisiness.
---
.../jackrabbit/oak/plugins/document/VersionGarbageCollector.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
index a4620ad7d2..ce650d8b28 100644
--- a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
+++ b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java
@@ -938,9 +938,9 @@ public class VersionGarbageCollector {
final Long modified = lastDoc.getModified();
if (modified == null) {
monitor.warn("collectFullGC : document has no _modified property : {}", doc.getId());
- } else if (SECONDS.toMillis(modified) < fromModifiedMs) {
- monitor.warn("collectFullGC : document has older _modified than query boundary : {} (from: {}, to: {})",
- modified, timestampToString(fromModifiedMs), timestampToString(toModifiedMs));
+ } else if (modified < MILLISECONDS.toSeconds(fromModifiedMs)) {
+ monitor.warn("collectFullGC : document has older _modified than query boundary : {} (from: {} [{}], to: {} [{}])",
+ modified, fromModifiedMs, timestampToString(fromModifiedMs), toModifiedMs, timestampToString(toModifiedMs));
}
}
// now remove the garbage in one go, if any