[GitHub] [daffodil] alexanderrevello commented on a change in pull request #768: Daffodil 2663 pluggable charsets

[GitBox <gi...@apache.org>]

alexanderrevello commented on a change in pull request #768:
URL: https://github.com/apache/daffodil/pull/768#discussion_r838686870



##########
File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/AISPayloadArmoring.scala
##########
@@ -44,3 +44,19 @@ object BitsCharsetAISPayloadArmoring extends {
   override val replacementCharCode = 0x30
   override val requiredBitOrder = BitOrder.MostSignificantBitFirst
 } with BitsCharsetNonByteSize
+
+final class BitsCharsetAISPayloadArmoringCompiler
+  extends CharsetCompiler("X-DAFFODIL-AIS-PAYLOAD-ARMORING") {
+
+  override def compileCharset() = {
+    new BitsCharsetAISPayloadArmoringTransformerFactory(name)

Review comment:
       name() is required for the SimpleNamedServiceLoader, however it does not need to be passed, the implementing class can just set it. I will change it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org