You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2025/07/29 17:30:00 UTC
[PR] cqssrt log field for TLS resumption type [trafficserver]
bneradt opened a new pull request, #12404:
URL: https://github.com/apache/trafficserver/pull/12404
This adds the cqssrt log field that indicates the TLS resumption type:
0: no resumption
1: server session cache resumption
2: TLS ticket resumption
---
# Draft
Starting this out as a draft until the dependand #12393 lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cqssrt log field for TLS resumption type [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #12404:
URL: https://github.com/apache/trafficserver/pull/12404#discussion_r2376690836
##########
include/proxy/http/HttpUserAgent.h:
##########
@@ -190,6 +193,14 @@ HttpUserAgent::set_txn(ProxyTransaction *txn, TransactionMilestones &milestones)
if (auto tsrs = netvc->get_service<TLSSessionResumptionSupport>()) {
m_conn_info.ssl_reused = tsrs->getIsResumedSSLSession();
+
+ if (tsrs->getIsResumedFromSessionCache()) {
+ m_conn_info.ssl_resumption_type = 1;
+ } else if (tsrs->getIsResumedFromSessionTicket()) {
+ m_conn_info.ssl_resumption_type = 2;
+ } else {
+ m_conn_info.ssl_resumption_type = 0;
Review Comment:
Could we have an assertion that checks `m_conn_info.ssl_reused == false` ? If yes, I think we could check the other two only if `ssl_reused` is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cqssrt log field for TLS resumption type [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12404:
URL: https://github.com/apache/trafficserver/pull/12404#issuecomment-3319543600
[approve ci autest 3]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cqssrt log field for TLS resumption type [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12404:
URL: https://github.com/apache/trafficserver/pull/12404#issuecomment-3133901086
[approve ci centos autest 2]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cqssrt log field for TLS resumption type [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #12404:
URL: https://github.com/apache/trafficserver/pull/12404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cqssrt log field for TLS resumption type [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12404:
URL: https://github.com/apache/trafficserver/pull/12404#issuecomment-3140470964
[approve ci autest 1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org