[jira] [Commented] (FLINK-7618) Add BINARY supported in FlinkTypeFactory

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166000#comment-16166000 ] 

ASF GitHub Bot commented on FLINK-7618:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/4669

    [FLINK-7618][table] Add BINARY supported in FlinkTypeFactory

    ## What is the purpose of the change
    
    *Add BINARY supported in FlinkTypeFactory*
    
    ## Brief change log
    
      - *Only improve `FlinkTypeFactory#toTypeInfo` add `BINARY` mapping to `PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO`*
    
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-7618-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4669
    
----
commit 441ec760c7534e97f504713eaec32de67f7e0b08
Author: sunjincheng121 <su...@gmail.com>
Date:   2017-09-14T09:22:41Z

    [FLINK-7618][table] Add BINARY supported in FlinkTypeFactory

----


> Add BINARY supported in FlinkTypeFactory
> ----------------------------------------
>
>                 Key: FLINK-7618
>                 URL: https://issues.apache.org/jira/browse/FLINK-7618
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> We will get the following exception when we deal with the BINARY type.
> {code}
> org.apache.flink.table.api.TableException: Type is not supported: BINARY
> 	at org.apache.flink.table.api.TableException$.apply(exceptions.scala:53)
> 	at org.apache.flink.table.calcite.FlinkTypeFactory$.toTypeInfo(FlinkTypeFactory.scala:377)
> 	at org.apache.flink.table.codegen.CodeGenerator.visitCall(CodeGenerator.scala:741)
> 	at org.apache.flink.table.codegen.CodeGenerator.visitCall(CodeGenerator.scala:67)
> 	at org.apache.calcite.rex.RexCall.accept(RexCall.java:104)
> 	at org.apache.flink.table.codegen.CodeGenerator$$anonfun$16.apply(CodeGenerator.scala:754)
> 	at org.apache.flink.table.codegen.CodeGenerator$$anonfun$16.apply(CodeGenerator.scala:744)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)