You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/30 08:22:49 UTC

[GitHub] [flink] sunhaibotb commented on issue #9252: [FLINK-13051][runtime] Replace the non-selectable stream task with the input-selectable one

sunhaibotb commented on issue #9252: [FLINK-13051][runtime] Replace the non-selectable stream task with the input-selectable one
URL: https://github.com/apache/flink/pull/9252#issuecomment-526509371
 
 
   Thanks for reviewing @pnowojski . The conflicts have resolved and test passed. 
   
   The benchmarking show that the **twoInputMapSink** test is faster than the master branch, and the **twoInputOneIdleMapSink** test is slower than the master branch, but the maximum result of the **twoInputOneIdleMapSink** test is larger than the master branch. On the whole, I don't think there's regression in performance. What do you think? @pnowojski 
   
   The test results of TwoInputBenchmark with bumping the number of forks to 15, are as follows.
   
   - **Results of the branch: master**
   ```
   Result "org.apache.flink.benchmark.TwoInputBenchmark.twoInputMapSink":
     8037.607 ±(99.9%) 415.634 ops/ms [Average]
     (min, avg, max) = (4630.272, 8037.607, 10680.036), stdev = 1516.361
     CI (99.9%): [7621.974, 8453.241] (assumes normal distribution)
   
   
   Result "org.apache.flink.benchmark.TwoInputBenchmark.twoInputOneIdleMapSink":
     4823.837 ±(99.9%) 177.680 ops/ms [Average]
     (min, avg, max) = (3131.426, 4823.837, 5814.206), stdev = 648.230
     CI (99.9%): [4646.157, 5001.517] (assumes normal distribution)
   
   
   # Run complete. Total time: 00:34:33
   
   Benchmark                                  Mode  Cnt     Score     Error   Units
   TwoInputBenchmark.twoInputMapSink         thrpt  150  8037.607 ± 415.634  ops/ms
   TwoInputBenchmark.twoInputOneIdleMapSink  thrpt  150  4823.837 ± 177.680  ops/ms
   ```
   
   - **Results of the branch: master + this PR**
   ```
   Result "org.apache.flink.benchmark.TwoInputBenchmark.twoInputMapSink":
     9520.452 ±(99.9%) 218.321 ops/ms [Average]
     (min, avg, max) = (6911.392, 9520.452, 11013.918), stdev = 796.504
     CI (99.9%): [9302.130, 9738.773] (assumes normal distribution)
   
   
   Result "org.apache.flink.benchmark.TwoInputBenchmark.twoInputOneIdleMapSink":
     4642.515 ±(99.9%) 192.741 ops/ms [Average]
     (min, avg, max) = (3219.666, 4642.515, 5885.845), stdev = 703.180
     CI (99.9%): [4449.774, 4835.257] (assumes normal distribution)
   
   
   # Run complete. Total time: 00:32:36
   
   Benchmark                                  Mode  Cnt     Score     Error   Units
   TwoInputBenchmark.twoInputMapSink         thrpt  150  9520.452 ± 218.321  ops/ms
   TwoInputBenchmark.twoInputOneIdleMapSink  thrpt  150  4642.515 ± 192.741  ops/ms
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services