[GitHub] [maven-surefire] Tibor17 commented on pull request #305: enable to flush regularly output of the forked process

[GitBox <gi...@apache.org>]

Tibor17 commented on pull request #305:
URL: https://github.com/apache/maven-surefire/pull/305#issuecomment-655482913


   @rmannibucau 
   Why you did it so complicated, the spaghetti code. Now we have to maintain this feature in several places.
   There is an abstrcation and the purpose it it is to make these non-functional changes hidden in the implementation. These two places are called only once, so it is easy just to put a Thread here and call the flush() method:
   https://github.com/apache/maven-surefire/blob/master/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelProcessorFactory.java#L65
   https://github.com/apache/maven-surefire/blob/master/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/SurefireMasterProcessChannelProcessorFactory.java#L107


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org