You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2013/12/31 03:35:22 UTC
Re: Review Request 11981: Adding base support for NVP security groups to the
NVP API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11981/#review30992
-----------------------------------------------------------
Reminder -
Hi,
This request has been pending for long. Please take the time to address the comments raised. Thanks!
- Amogh Vasekar
On June 19, 2013, 9:28 p.m., Adrian Steer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11981/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 9:28 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is initial version of API implementation of security groups within the NVP API
>
>
> Diffs
> -----
>
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java c571458
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraAddressPairs.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraLogicalPortRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 12fa6c0
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraSecurityProfile.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11981/diff/
>
>
> Testing
> -------
>
> Compile testing
>
>
> Thanks,
>
> Adrian Steer
>
>
Re: Review Request 11981: Adding base support for NVP security groups
to the NVP API
Posted by David Nalley <da...@gnsa.us>.
On Tue, Jan 14, 2014 at 9:29 AM, Hugo Trippaers
<ht...@schubergphilis.com> wrote:
>
>
>> On Dec. 31, 2013, 2:35 a.m., Amogh Vasekar wrote:
>> > Reminder -
>> >
>> > Hi,
>> > This request has been pending for long. Please take the time to address the comments raised. Thanks!
>
> This request can be marked as abandoned.
>
>
Done
--David
Re: Review Request 11981: Adding base support for NVP security groups to the
NVP API
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
> On Dec. 31, 2013, 2:35 a.m., Amogh Vasekar wrote:
> > Reminder -
> >
> > Hi,
> > This request has been pending for long. Please take the time to address the comments raised. Thanks!
This request can be marked as abandoned.
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11981/#review30992
-----------------------------------------------------------
On June 19, 2013, 9:28 p.m., Adrian Steer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11981/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 9:28 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is initial version of API implementation of security groups within the NVP API
>
>
> Diffs
> -----
>
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java c571458
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraAddressPairs.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraLogicalPortRule.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 12fa6c0
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraSecurityProfile.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11981/diff/
>
>
> Testing
> -------
>
> Compile testing
>
>
> Thanks,
>
> Adrian Steer
>
>