[jira] [Commented] (PHOENIX-5635) Refactor curator dependency handling and clean up erroneous direct references

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998445#comment-16998445 ] 

Hadoop QA commented on PHOENIX-5635:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12989025/PHOENIX-5635.master.v1.patch
  against master branch at commit 9e20c20f6b51c83f001fa5ea901e7db44480d189.
  ATTACHMENT ID: 12989025

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3200//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3200//console

This message is automatically generated.

> Refactor curator dependency handling and clean up erroneous direct references
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5635
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5635
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 5.1.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Minor
>         Attachments: PHOENIX-5635.master.v1.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The way we currently override the Omid curator version by excluding it from omid, and directly depending on is needlessly complex.
> It is much more straightforward to use dependencyManagement for this purpose.
> Also there a few places in the code that refer to the shaded guava List class in curator, instead of directly to guava for no discernible reason (probably IDE automation chose the curator class)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)