You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/25 12:29:30 UTC
[GitHub] [flink-ml] lindong28 opened a new pull request #38: [hotfix] Rename flink-ml-api to flink-ml-core
lindong28 opened a new pull request #38:
URL: https://github.com/apache/flink-ml/pull/38
## What is the purpose of the change
Currently we have `flink-ml-api` and `flink-ml-lib` modules. `flink-ml-api` contains classes needed by algorithm developers to developer algorithms, such as `BLAS` and `Vector`. `flink-ml-lib` contains algorithm classes that can be directly used by algorithm users, such as `KMeans`.
Conceptually speaking, classes such as `BLAS` and `Vector` are not APIs. Thus the name `flink-ml-api` may be a bit misleading.
This PR renames the `flink-ml-api` module to the `flink-ml-core` module to make the module name more intuitive.
## Brief change log
This PR makes the following changes:
- Renames the `flink-ml-api` module to the `flink-ml-core` module .
- Changes the package of `Stage` and related classes from `org.apache.flink.ml.api.core` to `org.apache.flink.ml.api`.
## Verifying this change
The change passes compilation and unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (N/A)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] gaoyunhaii commented on pull request #38: [hotfix] Rename flink-ml-api to flink-ml-core
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #38:
URL: https://github.com/apache/flink-ml/pull/38#issuecomment-979768035
Very thanks @lindong28 for the PR! LGTM and merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 commented on pull request #38: [hotfix] Rename flink-ml-api to flink-ml-core
Posted by GitBox <gi...@apache.org>.
lindong28 commented on pull request #38:
URL: https://github.com/apache/flink-ml/pull/38#issuecomment-979806357
@gaoyunhaii Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] gaoyunhaii closed pull request #38: [hotfix] Rename flink-ml-api to flink-ml-core
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #38:
URL: https://github.com/apache/flink-ml/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 commented on pull request #38: [hotfix] Rename flink-ml-api to flink-ml-core
Posted by GitBox <gi...@apache.org>.
lindong28 commented on pull request #38:
URL: https://github.com/apache/flink-ml/pull/38#issuecomment-979172355
@becketqin Could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org