You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2018/03/08 00:01:45 UTC
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9545
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
IMPALA-6617: Improve diagnostics for debugging.
The root cause of IMPALA-6671 is elusive.
This patch enhances the exception message to help
identify the root cause when we hit IMPALA-6617 again.
Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
---
M fe/src/main/java/org/apache/impala/service/FeSupport.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/9545/1
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 3: Code-Review+2
rebase, +2
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:49:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9545/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9545/1//COMMIT_MSG@9
PS1, Line 9: 6671
> typo?
Done
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:48:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2060/
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:50:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9545
to look at the new patch set (#2).
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
IMPALA-6617: Improve diagnostics for debugging.
The root cause of IMPALA-6617 is elusive.
This patch enhances the exception message to help
identify the root cause when we hit IMPALA-6617 again.
Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
---
M fe/src/main/java/org/apache/impala/service/FeSupport.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/9545/2
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 06:48:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9545/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9545/1//COMMIT_MSG@9
PS1, Line 9: 6671
typo?
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:43:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:48:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 1:
The new exception message looks like this:
ERROR: IllegalStateException: Illegal expr eval result. Expr=NULL < 10
TExpBatch=TExprBatch(exprs:[TExpr(nodes:[TExprNode(node_type:FUNCTION_CALL, type:TColumnType(types:[TTypeNode(type:SCALAR, scalar_type:TScalarType(type:BOOLEAN))]), num_children:2, is_constant:true, fn:TFunction(name:TFunctionName(db_name:_impala_builtins, function_name:lt), binary_type:BUILTIN, arg_types:[TColumnType(types:[TTypeNode(type:SCALAR, scalar_type:TScalarType(type:INT))]), TColumnType(types:[TTypeNode(type:SCALAR, scalar_type:TScalarType(type:INT))])], ret_type:TColumnType(types:[TTypeNode(type:SCALAR, scalar_type:TScalarType(type:BOOLEAN))]), has_var_args:false, signature:lt(INT, INT), scalar_fn:TScalarFunction(symbol:_ZN6impala9Operators16Lt_IntVal_IntValEPN10impala_udf15FunctionContextERKNS1_6IntValES6_), is_persistent:true)), TExprNode(node_type:NULL_LITERAL, type:TColumnType(types:[TTypeNode(type:SCALAR, scalar_type:TScalarType(type:INT))]), num_children:0, is_constant:true), TExprNode(node_type:INT_LITERAL, type:TColumnType(types:[TTypeNode(type:SCALAR, scalar_type:TScalarType(type:INT))]), num_children:0, is_constant:true, int_literal:TIntLiteral(value:10))])])
Result=TResultRow(colVals:[TColumnValue()])
I manually confirmed that the message is also dumped to the impalad log.
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 00:02:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:48:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9545 )
Change subject: IMPALA-6617: Improve diagnostics for debugging.
......................................................................
IMPALA-6617: Improve diagnostics for debugging.
The root cause of IMPALA-6617 is elusive.
This patch enhances the exception message to help
identify the root cause when we hit IMPALA-6617 again.
Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Reviewed-on: http://gerrit.cloudera.org:8080/9545
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/service/FeSupport.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I36e2c1185836262759c809632d69d0126af9bdbf
Gerrit-Change-Number: 9545
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>