You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/11/21 05:33:48 UTC

[GitHub] judby commented on a change in pull request #2: Implement MRRESOURCES-102

judby commented on a change in pull request #2: Implement MRRESOURCES-102
URL: https://github.com/apache/maven-remote-resources-plugin/pull/2#discussion_r235258316
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java
 ##########
 @@ -847,8 +853,7 @@ protected boolean copyResourceIfExists( File file, String relFileName, VelocityC
                 }
                 else if ( resource.isFiltering() )
                 {
-
-                    MavenFileFilterRequest req = setupRequest( resource, source, file );
+                    MavenFileFilterRequest req = setupRequest( source, file, resource.isFiltering() );
 
 Review comment:
   `req = setupRequest( source, file, true );`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services