[GitHub] [cassandra] alex-ninja commented on a change in pull request #950: CASSANDRA-16404. Provide a nodetool way of invalidating auth caches.

[GitBox <gi...@apache.org>]

alex-ninja commented on a change in pull request #950:
URL: https://github.com/apache/cassandra/pull/950#discussion_r617043396



##########
File path: src/java/org/apache/cassandra/auth/jmx/AuthorizationProxy.java
##########
@@ -490,5 +491,17 @@ protected JMXPermissionsCache()
                   AuthorizationProxy::loadPermissions,
                   () -> true);
         }
+
+        public void invalidatePermissions(String roleName)
+        {
+            invalidate(RoleResource.role(roleName));
+        }
+    }
+
+    public static interface JmxPermissionsCacheMBean extends AuthCacheMBean
+    {
+        public static final String CACHE_NAME = "JMXPermissionsCache";

Review comment:
       Even though the class is renamed, I've kept the same name for JMX bean. It does not affect anything. Please, let me know if it is safe to rename the bean name as well.

##########
File path: src/java/org/apache/cassandra/tools/NodeTool.java
##########
@@ -472,29 +476,6 @@ else if (defaultKeyspaceSet == KeyspaceSet.NON_SYSTEM)
         }
     }
 
-    public static SortedMap<String, SetHostStat> getOwnershipByDc(NodeProbe probe, boolean resolveIp,

Review comment:
       It was an unused method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org