You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/05/10 18:14:08 UTC

[GitHub] [submarine] kevin85421 opened a new pull request #584: SUBMARINE-825. Handle non-namespaced resources in delete event handler 

kevin85421 opened a new pull request #584:
URL: https://github.com/apache/submarine/pull/584


   ### What is this PR for?
   Resources can be categorized into four categories
   
   Type 1: namespaced resource created by client-go API
   
   Type 2: non-namespaced resource created by client-go API, ex: persistent volume
   
   Type 3: namespaced resource created by Helm API
   
   Type 4: non-namespaced resource created by Helm API, ex: clusterrole (traefik)
   
   Currently, the delete event resource handler can handle type 1, 2, 3 , but this is not enough. Thus, this Jira aims to handle Type 4.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-825
   
   ### How should this be tested?
   ```
   # Step1: Out-of-cluster
   go build -o submarine-operator
   ./submarine-operator
   
   # Step2: Create submarine in namespace "submarine-operator-test"
   kubectl create ns submarine-operator-test
   kubectl apply -n submarine-operator-test -f artifacts/examples/example-submarine.yaml
   
   # Step2: Delete Custom Resource
   kubectl delete submarine example-submarine -n submarine-operator-test
   
   # Step3: Check the result (non-namespaced resources)
   kubectl get ns 
   kubectl get pv
   kubectl get clusterrole
   
   # Step4: Create submarine in namespace "submarine-operator-test-2"
   kubectl create ns submarine-operator-test-2
   kubectl apply -n submarine-operator-test-2 -f artifacts/examples/example-submarine.yaml
   
   # Step5: Delete Custom Resource
   kubectl delete submarine example-submarine -n submarine-operator-test-2
   
   # Step6: Check the result (non-namespaced resources)
   kubectl get ns
   kubectl get pv
   kubectl get clusterrole
   ```
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #584: SUBMARINE-825. Handle non-namespaced resources in delete event handler

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #584:
URL: https://github.com/apache/submarine/pull/584


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kevin85421 commented on pull request #584: SUBMARINE-825. Handle non-namespaced resources in delete event handler

Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #584:
URL: https://github.com/apache/submarine/pull/584#issuecomment-837667543


   @Kenchu123 can you help me review this PR? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org