You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by Lari Hotari <lh...@apache.org> on 2022/10/04 16:31:13 UTC

Pulsar CI is currently broken in a way that it allows merging PRs with test failures

Hi all,

Currently, Pulsar CI allows merging PR with test failures and at least one PR has already been merged that contain failing tests. 
Please don't trust the green merge button. Please don't merge PRs without verifying that all necessary tests pass!

https://github.com/apache/pulsar/pull/17926 fixes the issue. Thanks to Tison and Nicolo for both working on the fix simultaneously. The fix for the test failures is in https://github.com/apache/pulsar/pull/17930 . After #17930 and #17926 are merged, the issue should be resolved.

 BR,

Lari

Re: Pulsar CI is currently broken in a way that it allows merging PRs with test failures

Posted by Lari Hotari <lh...@apache.org>.

The fixes have been merged. However, existing PRs don't automatically get the changes, so please be aware when merging PRs in the upcoming days.

-Lari

On 2022/10/04 16:31:13 Lari Hotari wrote:
> Hi all,
> 
> Currently, Pulsar CI allows merging PR with test failures and at least one PR has already been merged that contain failing tests. 
> Please don't trust the green merge button. Please don't merge PRs without verifying that all necessary tests pass!
> 
> https://github.com/apache/pulsar/pull/17926 fixes the issue. Thanks to Tison and Nicolo for both working on the fix simultaneously. The fix for the test failures is in https://github.com/apache/pulsar/pull/17930 . After #17930 and #17926 are merged, the issue should be resolved.
> 
>  BR,
> 
> Lari
>