You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2014/09/03 15:44:52 UTC
[jira] [Reopened] (HBASE-11876) RegionScanner.nextRaw(...) should
not update metrics
[ https://issues.apache.org/jira/browse/HBASE-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell reopened HBASE-11876:
------------------------------------
The trunk change passed precommit but the 0.98 version requires an addendum to fix a failing test, see https://builds.apache.org/job/HBase-0.98/493/testReport/org.apache.hadoop.hbase.regionserver/TestRegionServerMetrics/testScanNext/
> RegionScanner.nextRaw(...) should not update metrics
> ----------------------------------------------------
>
> Key: HBASE-11876
> URL: https://issues.apache.org/jira/browse/HBASE-11876
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.6
> Reporter: Lars Hofhansl
> Assignee: Andrew Purtell
> Fix For: 0.99.0, 2.0.0, 0.98.6
>
> Attachments: HBASE-11876-0.98.patch, HBASE-11876.patch, HBASE-11876.patch
>
>
> I added the RegionScanner.nextRaw(...) to allow "smart" client to avoid some of the default work that HBase is doing, such as {start|stop}RegionOperation and synchronized(scanner) for each row.
> Metrics should follow the same approach. Collecting them per row is expensive and a caller should have the option to collect those later or to avoid collecting them completely.
> We can also save some cycles in RSRcpServices.scan(...) if we updated the metric only once/batch instead of each row.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)