You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 20:54:34 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #26118: Move send_file method into SlackHook
Taragolis opened a new pull request, #26118:
URL: https://github.com/apache/airflow/pull/26118
Move send_file into SlackHook which make this part reusable in other Operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #26118: Move send_file method into SlackHook
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #26118:
URL: https://github.com/apache/airflow/pull/26118#discussion_r961094145
##########
airflow/providers/slack/operators/slack.py:
##########
@@ -154,7 +156,7 @@ class SlackAPIFileOperator(SlackAPIOperator):
task_id="slack_file_upload_1",
dag=dag,
slack_conn_id="slack",
- channel="#general",
+ channels="#general,#random",
Review Comment:
Slack API `files.upload` method supports upload file to multiple channels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26118: Move send_file method into SlackHook
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26118:
URL: https://github.com/apache/airflow/pull/26118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #26118: Move send_file method into SlackHook
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #26118:
URL: https://github.com/apache/airflow/pull/26118#discussion_r961093660
##########
airflow/providers/slack/operators/slack.py:
##########
@@ -70,14 +77,9 @@ def construct_api_call_params(self) -> Any:
)
def execute(self, **kwargs):
- """
- The SlackAPIOperator calls will not fail even if the call is not unsuccessful.
- It should not prevent a DAG from completing in success
- """
Review Comment:
Actually slack_sdk v3 always validate response and raise an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #26118: Move send_file method into SlackHook
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #26118:
URL: https://github.com/apache/airflow/pull/26118#discussion_r961094145
##########
airflow/providers/slack/operators/slack.py:
##########
@@ -154,7 +156,7 @@ class SlackAPIFileOperator(SlackAPIOperator):
task_id="slack_file_upload_1",
dag=dag,
slack_conn_id="slack",
- channel="#general",
+ channels="#general,#random",
Review Comment:
Slack API file.upload method supports upload file to multiple channels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org