[GitHub] [tvm] guberti commented on a change in pull request #8940: [microTVM] Refactor `platform` used as board name in microTVM

[GitBox <gi...@apache.org>]

guberti commented on a change in pull request #8940:
URL: https://github.com/apache/tvm/pull/8940#discussion_r705577741



##########
File path: apps/microtvm/arduino/template_project/microtvm_api_server.py
##########
@@ -43,6 +43,19 @@
 
 IS_TEMPLATE = not (API_SERVER_DIR / MODEL_LIBRARY_FORMAT_RELPATH).exists()
 
+# Maps a short, identifying microtvm device string to (target, arduino_board).
+MICRO_DEVICES = {

Review comment:
       I like this change - looks good for now. In a future PR, I would like to revisit how boards are specified, to make it easier for users to use boards that aren't explicitly in `BOARD_PROPERTIES`.

##########
File path: apps/microtvm/reference-vm/README.md
##########
@@ -72,20 +72,20 @@ For example:
 $ ./base-box-tool.py --provider virtualbox build zephyr
 ```
 
-2. **Run** release tests for each platform:
+2. **Run** release tests for each microTVM device:

Review comment:
       LGTM!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org