You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "hingu-8103 (via GitHub)" <gi...@apache.org> on 2026/07/10 13:17:49 UTC
[PR] fix(deps): remove redundant hugegraph-commons.version property [hugegraph]
hingu-8103 opened a new pull request, #3089:
URL: https://github.com/apache/hugegraph/pull/3089
## Purpose of the PR
- close #3088
The `hugegraph-commons` module is already versioned by `${revision}`.
At the same time, the root POM defines a separate property `hugegraph-commons.version` that tracks the same value.
This creates a duplicated version source for the same module family.
## Main Changes
- Remove `hugegraph-commons.version` from root `pom.xml`
- Replace `${hugegraph-commons.version}` with `${project.version}` in:
- `hugegraph-server/pom.xml`
- `hugegraph-store/hg-store-rocksdb/pom.xml`
- `hugegraph-pd/hg-pd-service/pom.xml`
- Keep version management consistent with existing project-level versioning
## Verifying these changes
- [x] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [ ] Need tests and can be verified as follows:
- N/A
## Does this PR potentially affect the following parts?
- [ ] Dependencies ([add/update license](https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses) info & [regenerate_known_dependencies.sh](../install-dist/scripts/dependency/regenerate_known_dependencies.sh))
- [x] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
- [ ] Nope
## Documentation Status
- [ ] `Doc - TODO`
- [ ] `Doc - Done`
- [x] `Doc - No Need`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(commons): remove redundant version property [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #3089:
URL: https://github.com/apache/hugegraph/pull/3089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(deps): remove redundant hugegraph-commons.version property [hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3089:
URL: https://github.com/apache/hugegraph/pull/3089#issuecomment-4937825048
## [Codecov](https://app.codecov.io/gh/apache/hugegraph/pull/3089?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 31.69%. Comparing base ([`2d63804`](https://app.codecov.io/gh/apache/hugegraph/commit/2d638042064b28dcbe6fe7cc39176c09d740fe5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9828811`](https://app.codecov.io/gh/apache/hugegraph/commit/982881135d011be27c85dae3e9c3fe8dc8e88f25?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (2d63804) and HEAD (9828811). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (2d63804) | HEAD (9828811) |
>|------|------|------|
>||4|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3089 +/- ##
============================================
- Coverage 37.96% 31.69% -6.28%
+ Complexity 519 498 -21
============================================
Files 805 816 +11
Lines 68404 69555 +1151
Branches 8993 9190 +197
============================================
- Hits 25968 22043 -3925
- Misses 39697 45110 +5413
+ Partials 2739 2402 -337
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph/pull/3089?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(deps): remove redundant hugegraph-commons.version property [hugegraph]
Posted by "hingu-8103 (via GitHub)" <gi...@apache.org>.
hingu-8103 commented on PR #3089:
URL: https://github.com/apache/hugegraph/pull/3089#issuecomment-4942388750
Hi @imbajin,
I've addressed your concern and updated stale reference to hugegraph-commons.version in version.properties. Can we re-trigger the pipeline ?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org