[GitHub] [incubator-superset] mistercrunch commented on issue #6610: Add support to Apache Drill

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #6610: Add support to Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-488546340
 
 
   I think the feature around `TABLE_NAMES_CACHE_CONFIG` when enabled makes it such that on the left panel, when schema is NOT selected, the table dropdown, instead of behind greyed out, will allow to search across all the tables in the database across schemas. This concatenates the `{schema}.{table_name}`.
   
   Now if we start having table names with periods in them, this stuff will get messed up. We'll either need proper quoting and quoting-aware splitting, or we need a better data structure, from say:
   
   ```json
   [
       "myschema.table1",
       "myschema2.table2"
   ]
   ```
   to:
   ```json
       {"schema": "myschema", "table": "table1"},
       {"schema": "myschema2", "table": "table2"}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org