You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mengccmumu (via GitHub)" <gi...@apache.org> on 2023/06/12 04:16:31 UTC
[GitHub] [dubbo-go] mengccmumu opened a new issue, #2339: common url OOM
mengccmumu opened a new issue, #2339:
URL: https://github.com/apache/dubbo-go/issues/2339
### Environment
<!--
- Server: Java, v3.2.1
- Client: Dubbo-go, v3.0.5
- Protocol: dubbo
- Registry: zk, v3.4.8
-->
- Server:
- Client:
- Protocol:
- Registry:
### Issue description
<!-- Here is a brief description about the issue. -->
OOM
### Logs
<details><summary>Click me to check logs</summary>
```
Copy logs to here.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] mengccmumu commented on issue #2339: common MergeURL OOM
Posted by "mengccmumu (via GitHub)" <gi...@apache.org>.
mengccmumu commented on issue #2339:
URL: https://github.com/apache/dubbo-go/issues/2339#issuecomment-1611013224
>
already verify this PR, but OOM still occurs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] welcome112s commented on issue #2339: common MergeURL OOM
Posted by "welcome112s (via GitHub)" <gi...@apache.org>.
welcome112s commented on issue #2339:
URL: https://github.com/apache/dubbo-go/issues/2339#issuecomment-1651308749
@mengccmumu
你这个oom解决了吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] mengccmumu commented on issue #2339: common MergeURL OOM
Posted by "mengccmumu (via GitHub)" <gi...@apache.org>.
mengccmumu commented on issue #2339:
URL: https://github.com/apache/dubbo-go/issues/2339#issuecomment-1617444658
> From the picture you provided, I don't see any leaks about the `MergeURL`.
you are right .
I will analyze the issue with OOM again .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] common MergeURL OOM [dubbo-go]
Posted by "licon (via GitHub)" <gi...@apache.org>.
licon commented on issue #2339:
URL: https://github.com/apache/dubbo-go/issues/2339#issuecomment-2017349621
我们在生产环境也遇到这个问题，希望能尽快解决
pprof list：
```
(pprof) list MergeURL
Total: 489.08MB
ROUTINE ======================== dubbo.apache.org/dubbo-go/v3/common.MergeURL in dubbo.apache.org/dubbo-go/v3@v3.0.2/common/url.go
271.67MB 324.67MB (flat, cum) 66.38% of Total
. . 681:// the params of result will be (a1->v1, b1->v2, a2->v3).
. . 682:// You should notice that the value of b1 is v2, not v4.
. . 683:// due to URL is not thread-safe, so this method is not thread-safe
. . 684:func MergeURL(serviceURL *URL, referenceURL *URL) *URL {
. . 685: // After Clone, it is a new URL that there is no thread safe issue.
. 52MB 686: mergedURL := serviceURL.Clone()
. . 687: params := mergedURL.GetParams()
. . 688: // iterator the referenceURL if serviceURL not have the key ,merge in
. . 689: // referenceURL usually will not changed. so change RangeParams to GetParams to avoid the string value copy.// Group get group
. . 690: for key, value := range referenceURL.GetParams() {
. . 691: if v := mergedURL.GetParam(key, ""); len(v) == 0 {
. . 692: if len(value) > 0 {
268.67MB 268.67MB 693: params[key] = value
. . 694: }
. . 695: }
. . 696: }
. . 697:
. . 698: // loadBalance,cluster,retries strategy config
. 1MB 699: methodConfigMergeFcn := mergeNormalParam(params, referenceURL, []string{constant.LoadbalanceKey, constant.ClusterKey, constant.RetriesKey, constant.TimeoutKey})
. . 700:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on issue #2339: common MergeURL OOM
Posted by "justxuewei (via GitHub)" <gi...@apache.org>.
justxuewei commented on issue #2339:
URL: https://github.com/apache/dubbo-go/issues/2339#issuecomment-1616387808
From the picture you provided, I don't see any leaks about the `MergeURL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] common MergeURL OOM [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks closed issue #2339: common MergeURL OOM
URL: https://github.com/apache/dubbo-go/issues/2339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on issue #2339: common MergeURL OOM
Posted by "justxuewei (via GitHub)" <gi...@apache.org>.
justxuewei commented on issue #2339:
URL: https://github.com/apache/dubbo-go/issues/2339#issuecomment-1596367752
Hi @mengccmumu, there was a pull request to fix this problem, see https://github.com/apache/dubbo-go/pull/2223. Could you help us verify this PR on your environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org