You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2023/04/05 07:36:47 UTC
[GitHub] [spark] allisonwang-db opened a new pull request, #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
allisonwang-db opened a new pull request, #40672:
URL: https://github.com/apache/spark/pull/40672
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR adds error classes, message parameters, and SQL states in the Spark Connect server's ErrorInfo. It also stores the error class and message parameters info in a `SparkConnectException` for the Python client.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make the error class programmatically accessible for python clients.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
URL: https://github.com/apache/spark/pull/40672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159756878
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,14 +31,12 @@ def __init__(
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
):
- # `message` vs `error_class` & `message_parameters` are mutually exclusive.
- assert (message is not None and (error_class is None and message_parameters is None)) or (
- message is None and (error_class is not None and message_parameters is not None)
- )
-
- self.error_reader = ErrorClassesReader()
-
if message is None:
+ assert (
Review Comment:
This follows the behavior on the JVM side. All errors should have either an error class and message parameters, or just a message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159217645
##########
python/pyspark/errors/exceptions/connect.py:
##########
@@ -46,40 +46,56 @@ class SparkConnectException(PySparkException):
def convert_exception(info: "ErrorInfo", message: str) -> SparkConnectException:
classes = []
+ error_class = None
+ message_parameters = None
+ # TODO: add sqlState in PySparkException.
Review Comment:
I believe that since `PySparkException` manages errors that are specifically raised by PySpark (not JVM), maybe there is no need to add `sqlState` to it.
The SQLSTATE of errors that occur in the JVM already can be obtained through the `getSqlState`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40672:
URL: https://github.com/apache/spark/pull/40672#issuecomment-1637231164
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159953337
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,14 +31,12 @@ def __init__(
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
):
- # `message` vs `error_class` & `message_parameters` are mutually exclusive.
- assert (message is not None and (error_class is None and message_parameters is None)) or (
- message is None and (error_class is not None and message_parameters is not None)
- )
-
- self.error_reader = ErrorClassesReader()
-
if message is None:
+ assert (
Review Comment:
Why can't these errors include all of the following: error messages, error classes, parameters, and SQL states? If the error message field is None, we can render the message from the error class and parameter. This approach allows us to check for error classes in PySpark unit tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159156260
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,14 +31,12 @@ def __init__(
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
):
- # `message` vs `error_class` & `message_parameters` are mutually exclusive.
- assert (message is not None and (error_class is None and message_parameters is None)) or (
- message is None and (error_class is not None and message_parameters is not None)
- )
-
- self.error_reader = ErrorClassesReader()
-
if message is None:
+ assert (
Review Comment:
we are losing the assert on `message is not None and (error_class is None and message_parameters is None)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159263436
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,14 +31,12 @@ def __init__(
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
):
- # `message` vs `error_class` & `message_parameters` are mutually exclusive.
- assert (message is not None and (error_class is None and message_parameters is None)) or (
- message is None and (error_class is not None and message_parameters is not None)
- )
-
- self.error_reader = ErrorClassesReader()
-
if message is None:
+ assert (
Review Comment:
It's just moved from the previous commit.
cc @itholic for the original author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159261915
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -229,8 +230,29 @@ def test_df_get_item(self):
def test_error_handling(self):
# SPARK-41533 Proper error handling for Spark Connect
df = self.connect.range(10).select("id2")
- with self.assertRaises(AnalysisException):
+ with self.assertRaises(AnalysisException) as e:
df.collect()
+ self.check_error(
+ exception=e.exception,
+ error_class="UNRESOLVED_COLUMN.WITH_SUGGESTION",
+ message_parameters=dict(objectName="`id2`", proposal="`id`")
+ )
+
+ def test_error_classes(self):
+ with self.assertRaises(ParseException) as e:
+ self.connect.sql("select ;")
+ self.assertEqual(e.exception.getErrorClass(), "PARSE_SYNTAX_ERROR")
+
+ self.connect.conf.set("spark.sql.ansi.enabled", True)
+ with self.assertRaises(ArithmeticException) as e:
+ self.connect.sql("select 1/0").collect()
+ self.assertEqual(e.exception.getErrorClass(), "DIVIDE_BY_ZERO")
+ self.connect.conf.set("spark.sql.ansi.enabled", False)
+
+ with self.assertRaises(SparkConnectException) as e:
+ df = self.connect.createDataFrame({'x': 1, 'y': 2})
+ df.write.mode("overwrite").format("noformat").saveAsTable("t")
+ self.assertEqual(e.exception.getErrorClass(), "DATA_SOURCE_NOT_FOUND")
Review Comment:
Our test cases don't cover the exceptions generated from JVM yet. Just created SPARK-43048 to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159215698
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -229,8 +230,29 @@ def test_df_get_item(self):
def test_error_handling(self):
# SPARK-41533 Proper error handling for Spark Connect
df = self.connect.range(10).select("id2")
- with self.assertRaises(AnalysisException):
+ with self.assertRaises(AnalysisException) as e:
df.collect()
+ self.check_error(
+ exception=e.exception,
+ error_class="UNRESOLVED_COLUMN.WITH_SUGGESTION",
+ message_parameters=dict(objectName="`id2`", proposal="`id`")
+ )
+
+ def test_error_classes(self):
+ with self.assertRaises(ParseException) as e:
+ self.connect.sql("select ;")
+ self.assertEqual(e.exception.getErrorClass(), "PARSE_SYNTAX_ERROR")
+
+ self.connect.conf.set("spark.sql.ansi.enabled", True)
+ with self.assertRaises(ArithmeticException) as e:
+ self.connect.sql("select 1/0").collect()
+ self.assertEqual(e.exception.getErrorClass(), "DIVIDE_BY_ZERO")
+ self.connect.conf.set("spark.sql.ansi.enabled", False)
+
+ with self.assertRaises(SparkConnectException) as e:
+ df = self.connect.createDataFrame({'x': 1, 'y': 2})
+ df.write.mode("overwrite").format("noformat").saveAsTable("t")
+ self.assertEqual(e.exception.getErrorClass(), "DATA_SOURCE_NOT_FOUND")
Review Comment:
FYI @gatorsmile here is the good example to test error class generated from JVM side on PySpark test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159217793
##########
python/pyspark/errors/exceptions/connect.py:
##########
@@ -46,40 +46,56 @@ class SparkConnectException(PySparkException):
def convert_exception(info: "ErrorInfo", message: str) -> SparkConnectException:
classes = []
+ error_class = None
+ message_parameters = None
+ # TODO: add sqlState in PySparkException.
Review Comment:
I believe that since `PySparkException` manages errors that are specifically raised by PySpark (not JVM), maybe there is no need to add `sqlState` to it?
Btw the SQLSTATE of errors that occur in the JVM already can be obtained through the `getSqlState`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159185385
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,14 +31,12 @@ def __init__(
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
):
- # `message` vs `error_class` & `message_parameters` are mutually exclusive.
- assert (message is not None and (error_class is None and message_parameters is None)) or (
- message is None and (error_class is not None and message_parameters is not None)
- )
-
- self.error_reader = ErrorClassesReader()
-
if message is None:
+ assert (
Review Comment:
Yes cc @ueshin I am wondering why do we need this assert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40672:
URL: https://github.com/apache/spark/pull/40672#issuecomment-1497083617
Nice. cc @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "gatorsmile (via GitHub)" <gi...@apache.org>.
gatorsmile commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159258510
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -229,8 +230,29 @@ def test_df_get_item(self):
def test_error_handling(self):
# SPARK-41533 Proper error handling for Spark Connect
df = self.connect.range(10).select("id2")
- with self.assertRaises(AnalysisException):
+ with self.assertRaises(AnalysisException) as e:
df.collect()
+ self.check_error(
+ exception=e.exception,
+ error_class="UNRESOLVED_COLUMN.WITH_SUGGESTION",
+ message_parameters=dict(objectName="`id2`", proposal="`id`")
+ )
+
+ def test_error_classes(self):
+ with self.assertRaises(ParseException) as e:
+ self.connect.sql("select ;")
+ self.assertEqual(e.exception.getErrorClass(), "PARSE_SYNTAX_ERROR")
+
+ self.connect.conf.set("spark.sql.ansi.enabled", True)
+ with self.assertRaises(ArithmeticException) as e:
+ self.connect.sql("select 1/0").collect()
+ self.assertEqual(e.exception.getErrorClass(), "DIVIDE_BY_ZERO")
+ self.connect.conf.set("spark.sql.ansi.enabled", False)
+
+ with self.assertRaises(SparkConnectException) as e:
+ df = self.connect.createDataFrame({'x': 1, 'y': 2})
+ df.write.mode("overwrite").format("noformat").saveAsTable("t")
+ self.assertEqual(e.exception.getErrorClass(), "DATA_SOURCE_NOT_FOUND")
Review Comment:
This only covers Spark Connect mode. How about the cases when Spark Connect is off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40672: [SPARK-43035][CONNECT] Add error class in Spark Connect server's ErrorInfo
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1160369876
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,14 +31,12 @@ def __init__(
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
):
- # `message` vs `error_class` & `message_parameters` are mutually exclusive.
- assert (message is not None and (error_class is None and message_parameters is None)) or (
- message is None and (error_class is not None and message_parameters is not None)
- )
-
- self.error_reader = ErrorClassesReader()
-
if message is None:
+ assert (
Review Comment:
> If the error message field is None, we can render the message from the error class and parameter.
Yes, the existing code already does that. We're doing basically:
1. if the `message` is `None`, we render the message from the `error_class` and `message_parameter`.
2. if the `message` exists, we use that message instead of `error_class` and `message_parameter`. In this case, `error_class` and `message_parameter` will never be used, so we block to accept them in force.
Your fix removes the second condition, so that's why @amaliujia concerned about this I guess.
btw, what is the reason for changing this code? Is there a case where we need to receive `message`, `error_class`, and `message_parameter` at the same time? If we cannot avoid it, I agree with this modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org