You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ruth Cao (JIRA)" <ji...@apache.org> on 2007/03/08 04:51:24 UTC

[jira] Created: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

[classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
---------------------------------------------------------------------------------------------

                 Key: HARMONY-3333
                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Ruth Cao


The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.

[1] public void test_equalsLjava_lang_Object() {
       SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
       SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
        assertTrue("Different cases should be equal", sp1.equals(sp2));
}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Ruth Cao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480298 ] 

Ruth Cao commented on HARMONY-3333:
-----------------------------------

Thank you very much, Richard. The fix looks fine at r517575. 

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Liang resolved HARMONY-3333.
------------------------------------

    Resolution: Fixed

Hello Ruth,

The patch has been applied at revision r517507. Thanks a lot for this enhancement, please verify this issue is fixed as you expected.

Best regards,
Richard.

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Liang resolved HARMONY-3333.
------------------------------------

    Resolution: Fixed

Hello Ruth,

I have removed the unnecessary check about the unresolved IP at revision 518014.

Best regards,
Richard.

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333-2.diff, Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Ruth Cao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481041 ] 

Ruth Cao commented on HARMONY-3333:
-----------------------------------

Thanks Richard. It works fine for me.

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333-2.diff, Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480282 ] 

Richard Liang commented on HARMONY-3333:
----------------------------------------

Hello Ruth,

Just notice that you didn't remove SocketPermissionTest  from the exclude.common file. I have done it at revision r517541.

Best regards,
Richard.

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Ruth Cao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Cao updated HARMONY-3333:
------------------------------

    Attachment: Harmony-3333-2.diff

I've created a new patch to fix this failure. Now if the IP address maps to a specific host name, the test case will not be run. Thanks.

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333-2.diff, Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Ruth Cao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Cao reopened HARMONY-3333:
-------------------------------


According to mailing list discussion, reopened this jira since it causes test failure under some specific environment.

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Ruth Cao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Cao updated HARMONY-3333:
------------------------------

    Attachment: Harmony-3333.diff

May somebody pls try this patch?

Besides, it seems that t.a.j.n.SocketPermissionTest has been passed on Harmony now. Could it be taken from the exclude list? Thanks a lot.

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Attachments: Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3333) [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Liang reassigned HARMONY-3333:
--------------------------------------

    Assignee: Richard Liang

> [classlib][luni]java.net.SocketPermission considers port even if the action is only 'resolve'
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3333
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3333
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ruth Cao
>         Assigned To: Richard Liang
>         Attachments: Harmony-3333.diff
>
>
> The following test case[1] fails on Harmony while passes on RI. It is due to SocketPermission considers port even if the action is only 'resolve' in Harmony. I'll upload a patch soon. Thanks.
> [1] public void test_equalsLjava_lang_Object() {
>        SocketPermission sp1 = new SocketPermission("TEST1.com:333", "resolve");
>        SocketPermission sp2 = new SocketPermission("test1.com:444", "resolve");
>         assertTrue("Different cases should be equal", sp1.equals(sp2));
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.