You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/08/05 19:25:45 UTC
[PR] [CELEBORN-1546] Support authorization on swagger UI [celeborn]
turboFei opened a new pull request, #2664:
URL: https://github.com/apache/celeborn/pull/2664
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title.
### Why are the changes needed?
Since celeborn already supports http authorization, it is better to enable authorization on swagger UI as well.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Integration testing.
<img width="1634" alt="image" src="https://github.com/user-attachments/assets/80b6fef4-2ace-4ec3-80aa-4b9bc98131d6">
<img width="1334" alt="image" src="https://github.com/user-attachments/assets/57e53db0-8d24-4568-add8-4c3b01f05404">
And it will not impact the service without authentication enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1546] Support authorization on swagger UI [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #2664: [CELEBORN-1546] Support authorization on swagger UI
URL: https://github.com/apache/celeborn/pull/2664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1546] Support authorization on swagger UI [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2664:
URL: https://github.com/apache/celeborn/pull/2664#issuecomment-2269792359
```
Error: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:install-node-and-pnpm (install node and pnpm) on project celeborn-web_2.12: Could not download Node.js: Could not download https://nodejs.org/dist/v20.11.0/node-v20.11.0-linux-x64.tar.gz: Premature end of Content-Length delimited message body (expected: 46,607,807; received: 4,096,000) -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1546] Support authorization on swagger UI [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2664:
URL: https://github.com/apache/celeborn/pull/2664#issuecomment-2270317552
Thanks, merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1546] Support authorization on swagger UI [celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2664:
URL: https://github.com/apache/celeborn/pull/2664#issuecomment-2270238977
Maybe we should also consider adding authorization support for Apache Kyuubi on Swagger UI? cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1546] Support authorization on swagger UI [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2664:
URL: https://github.com/apache/celeborn/pull/2664#issuecomment-2269761107
cc @pan3793 @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org