You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by laimis <gi...@git.apache.org> on 2016/01/08 22:32:51 UTC
[GitHub] lucenenet pull request: Port of CharTokenizer, other code it depen...
GitHub user laimis opened a pull request:
https://github.com/apache/lucenenet/pull/159
Port of CharTokenizer, other code it depends on and corresponding tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laimis/lucenenet analysis_chartokenizer_port
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit 4dcbcd1adb698a5eb18616e67ff115e00fcd158b
Author: Laimonas Simutis <la...@gmail.com>
Date: 2016-01-08T21:30:47Z
port of CharTokenizer and other code it depends on, and corresponding unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Port of CharTokenizer, other code it depen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Port of CharTokenizer, other code it depen...
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/159#discussion_r49704493
--- Diff: src/Lucene.Net.Analysis.Common/Analysis/Core/LetterTokenizer.cs ---
@@ -75,10 +75,10 @@ public LetterTokenizer(LuceneVersion matchVersion, AttributeSource.AttributeFact
/// <summary>
/// Collects only characters which satisfy
/// <seealso cref="Character#isLetter(int)"/>.
- /// </summary>
- protected override bool IsTokenChar(char c)
+ /// </summary>
+ protected override bool IsTokenChar(int c)
--- End diff --
IIRC I tried keeping it a char for .NET-ification reasons, but I can see how UTF32 can force us back to int
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---