You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Gustavo Niemeyer <ni...@conectiva.com> on 2002/10/31 15:04:00 UTC

[PATCH] bdb library names

Good morning (almost afternoon)!

I'm currently using the 'all-static' patch to provide a static compiled
packages which can easily be used in old machines. When using this patch
a small issue is raised by the way the berkeley db is currently
detected.

Usually bdb has either a link named "libdb4.so" or simply "libdb.so",
which is correctly detected by subversion. OTOH, these links are
pointing to a library named "libdb-4.0.{la,so,a}". When compiling the
dynamic version there's no problem, since it's happy enough to link
with "libdb{,4}.so", but when compiling statically, it looks for a
library named "libdb4.{la,a}", which doesn't exist.

The small patch bellow includes "db-4.0" as the first option for
berkeley db detection, fixing this problem. This should not affect
normal compilation (famous last words :-).

(Perhaps it could be even the only option detected, but I haven't
 done an extensive research to check if every distribution is using
 the same naming conventions)


* configure.in: Include db-4.0 as first option for detecting bdb.


--- configure.in.db4	2002-10-30 17:02:20.000000000 -0300
+++ configure.in	2002-10-31 11:52:56.000000000 -0300
@@ -146,9 +146,9 @@
 SVN_FS_WANT_DB_MAJOR=4
 SVN_FS_WANT_DB_MINOR=0
 SVN_FS_WANT_DB_PATCH=14
-# Look for libdb4.so first:
+# Look for libdb-4.0.so, then libdb4.so, and at last libdb.so:
 SVN_LIB_BERKELEY_DB($SVN_FS_WANT_DB_MAJOR, $SVN_FS_WANT_DB_MINOR,
-                    $SVN_FS_WANT_DB_PATCH, [db4 db])
+                    $SVN_FS_WANT_DB_PATCH, [db-4.0 db4 db])
 
 SVN_LIB_XMLRPC_EPI()
 

-- 
Gustavo Niemeyer

[ 2AAC 7928 0FBF 0299 5EB5  60E2 2253 B29A 6664 3A0C ]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] bdb library names

Posted by Gustavo Niemeyer <ni...@conectiva.com>.
> What about db-4.1, then? We just went through a lot of pain to make the 
> 4.0/4.1 detection automagic and symmetric -- your patch breaks that just 
> a bit.

Just include db-4.1 as the first option, or forget it completely. I can
handle it by myself.

-- 
Gustavo Niemeyer

[ 2AAC 7928 0FBF 0299 5EB5  60E2 2253 B29A 6664 3A0C ]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] bdb library names

Posted by Branko Čibej <br...@xbc.nu>.
Gustavo Niemeyer wrote:

>Good morning (almost afternoon)!
>
>I'm currently using the 'all-static' patch to provide a static compiled
>packages which can easily be used in old machines. When using this patch
>a small issue is raised by the way the berkeley db is currently
>detected.
>
>Usually bdb has either a link named "libdb4.so" or simply "libdb.so",
>which is correctly detected by subversion. OTOH, these links are
>pointing to a library named "libdb-4.0.{la,so,a}". When compiling the
>dynamic version there's no problem, since it's happy enough to link
>with "libdb{,4}.so", but when compiling statically, it looks for a
>library named "libdb4.{la,a}", which doesn't exist.
>
>The small patch bellow includes "db-4.0" as the first option for
>berkeley db detection, fixing this problem. This should not affect
>normal compilation (famous last words :-).
>
>(Perhaps it could be even the only option detected, but I haven't
> done an extensive research to check if every distribution is using
> the same naming conventions)
>
>
>* configure.in: Include db-4.0 as first option for detecting bdb.
>
What about db-4.1, then? We just went through a lot of pain to make the 
4.0/4.1 detection automagic and symmetric -- your patch breaks that just 
a bit.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org