[GitHub] [flink] Myasuka commented on a change in pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default

[GitBox <gi...@apache.org>]

Myasuka commented on a change in pull request #14656:
URL: https://github.com/apache/flink/pull/14656#discussion_r566213388



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/rpc/RpcCheckpointResponder.java
##########
@@ -55,7 +56,16 @@ public void declineCheckpoint(
             long checkpointId,
             Throwable cause) {
 
+        // TODO the passed parameter 'cause' is actually always instance of CheckpointException,
+        //  we should change the interfaces to narrow all declined checkpoint's throwable to
+        // CheckpointException.

Review comment:
       I don't want to break the API compatibility to refactor APIs in minor version of Flink, and we could still achieve the effect to make job could fail if async checkpoint failed without refactoring APIs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org