You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Rakesh Gupta <ra...@gmail.com> on 2024/10/22 07:22:27 UTC

Review Request 75237: RANGER-4777: Improve API /public/v2/api/service-headers to filter services depending on user role

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75237/
-----------------------------------------------------------

Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4777
    https://issues.apache.org/jira/browse/RANGER-4777


Repository: ranger


Description
-------

Need to update the API - "/public/v2/api/service-headers" introduce in RANGER-4533 with below :


The API should be accessible for non-admin users as well. @PreAuthrize annotation can be removed.
Filtering of services depending on user role like done for existing API - "/plugins/services"


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java 7303bc746 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 0d0102288 
  security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java a7726d780 
  security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java 9e1fb13ef 
  security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java eb7fc05ae 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 3aeda199a 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 435b78679 
  security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java d8284dff6 
  security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIMapping.java 59cd2a6dc 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 616ce9924 


Diff: https://reviews.apache.org/r/75237/diff/1/


Testing
-------

Tested "/public/v2/api/service-headers" API is accessible for non-admin users.


Thanks,

Rakesh Gupta


Re: Review Request 75237: RANGER-4777: Improve API /public/v2/api/service-headers to filter services depending on user role

Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75237/#review226994
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On Oct. 22, 2024, 7:22 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75237/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2024, 7:22 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4777
>     https://issues.apache.org/jira/browse/RANGER-4777
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Need to update the API - "/public/v2/api/service-headers" introduce in RANGER-4533 with below :
> 
> 
> The API should be accessible for non-admin users as well. @PreAuthrize annotation can be removed.
> Filtering of services depending on user role like done for existing API - "/plugins/services"
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java 7303bc746 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 0d0102288 
>   security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java a7726d780 
>   security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java 9e1fb13ef 
>   security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java eb7fc05ae 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 3aeda199a 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 435b78679 
>   security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java d8284dff6 
>   security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIMapping.java 59cd2a6dc 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 616ce9924 
> 
> 
> Diff: https://reviews.apache.org/r/75237/diff/1/
> 
> 
> Testing
> -------
> 
> Tested "/public/v2/api/service-headers" API is accessible for non-admin users.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>