[jira] [Commented] (ARROW-782) [C++] Change struct to class for objects that meet the criteria in the Google style guide

["Rok Mihevc (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657814#comment-17657814 ] 

Rok Mihevc commented on ARROW-782:
----------------------------------

This issue has been migrated to [issue #16394|https://github.com/apache/arrow/issues/16394] on GitHub. Please see the [migration documentation|https://github.com/apache/arrow/issues/14542] for further details.

> [C++] Change struct to class for objects that meet the criteria in the Google style guide
> -----------------------------------------------------------------------------------------
>
>                 Key: ARROW-782
>                 URL: https://issues.apache.org/jira/browse/ARROW-782
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>             Fix For: 0.3.0
>
>
> See https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes. I have suspected that the types in {{type.h}} should be classes, but this suggests it pretty strongly. It would be better to address this sooner rather than later. 
> We should also make the member access functions instead of bare attributes, e.g. {{type->id()}} instead of {{type->type}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)